From: Pierre Morel <pmorel@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com,
cohuck@redhat.com, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
frankja@linux.ibm.com, akrowiak@linux.ibm.com, david@redhat.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
freude@linux.ibm.com, mimu@linux.ibm.com
Subject: Re: [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel
Date: Tue, 30 Apr 2019 13:00:55 +0200 [thread overview]
Message-ID: <e000d0b8-c5fa-bdc1-10f3-2bebae7ccdfe@linux.ibm.com> (raw)
In-Reply-To: <20190430113718.426392f0.pasic@linux.ibm.com>
On 30/04/2019 11:37, Halil Pasic wrote:
> On Tue, 30 Apr 2019 10:32:52 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>>>>> + aqic_gisa.gisa = gisa->next_alert >> 4;
>>>>
>>>> Why gisa->next_alert? Isn't this supposed to get set to gisa origin
>>>> (without some bits on the left)?
>
> s/left/right/
>
>>>
>>> Someone already asked this question.
>
> It must have been in some previous iteration... Can you give me a
> pointer?
>
>>> The answer is: look at the ap_qirq_ctrl structure, you will see that the
>>> gisa field is 27 bits wide.
>
> My question was not about the width, but about gisa->next_alert being
> used.
>
> Regards,
> Halil
>
Ah, OK, I understand.
it is inherited from the time I allocated the GISA myself, before the
Mimu GISA/GIB patches.
So now indeed I must use the GISA origin for the case next_alert is used
by GIB alert queue.
--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
next prev parent reply other threads:[~2019-04-30 11:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 13:01 [PATCH v7 0/4] vfio: ap: AP Queue Interrupt Control Pierre Morel
2019-04-26 13:01 ` [PATCH v7 1/4] s390: ap: kvm: add PQAP interception for AQIC Pierre Morel
2019-04-26 13:01 ` [PATCH v7 2/4] vfio: ap: register IOMMU VFIO notifier Pierre Morel
2019-04-29 16:07 ` Halil Pasic
2019-04-30 7:59 ` Pierre Morel
2019-04-30 9:29 ` Halil Pasic
2019-04-26 13:01 ` [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel Pierre Morel
2019-04-29 16:50 ` Halil Pasic
2019-04-30 8:18 ` Pierre Morel
2019-04-30 8:32 ` Pierre Morel
2019-04-30 9:37 ` Halil Pasic
2019-04-30 11:00 ` Pierre Morel [this message]
2019-04-30 13:26 ` Halil Pasic
2019-04-30 14:09 ` Pierre Morel
2019-05-02 7:57 ` Pierre Morel
2019-04-30 14:00 ` Halil Pasic
2019-04-30 14:03 ` Pierre Morel
2019-04-26 13:01 ` [PATCH v7 4/4] s390: ap: kvm: Enable PQAP/AQIC facility for the guest Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e000d0b8-c5fa-bdc1-10f3-2bebae7ccdfe@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox