From: Kai <KaiShen@linux.alibaba.com>
To: Wenjia Zhang <wenjia@linux.ibm.com>,
kgraul@linux.ibm.com, jaka@linux.ibm.com
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2] net/smc: Use percpu ref for wr tx reference
Date: Tue, 28 Feb 2023 19:34:45 +0800 [thread overview]
Message-ID: <e10d76c4-3b2c-b906-07c3-9a42b1c485bb@linux.alibaba.com> (raw)
In-Reply-To: <b869713b-7f1d-4093-432c-9f958f5bd719@linux.ibm.com>
On 2023/2/28 6:55 下午, Wenjia Zhang wrote:
> @Kai, the performance improvement seems not so giant, but the method
> looks good, indeed. However, to keep the consistency of the code, I'm
> wondering why you only use the perf_ref for wr_tx_wait, but not for
> wr_reg_refcnt?
Didn't check the similar refcnt, my bad.
On the other hand, Our work is inspired by performance analysis, it
seems wr_reg_refcnt is not on the IO path. It may not contribute to
performance improvement.
And inspired by your comment, it seems we can also make the refcnt
cdc_pend_tx_wr a perfcpu one. I will look into this.
Thanks
next prev parent reply other threads:[~2023-02-28 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 12:16 [PATCH net-next v2] net/smc: Use percpu ref for wr tx reference Kai
2023-02-28 10:55 ` Wenjia Zhang
2023-02-28 11:34 ` Kai [this message]
2023-02-28 12:15 ` Guangguan Wang
2023-02-28 12:20 ` Kai
2023-02-28 12:52 ` Wenjia Zhang
2023-03-01 1:44 ` Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10d76c4-3b2c-b906-07c3-9a42b1c485bb@linux.alibaba.com \
--to=kaishen@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox