public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Nico Boehr <nrb@linux.ibm.com>,
	frankja@linux.ibm.com, imbrenda@linux.ibm.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v6 6/8] s390x: add test source dir to include paths
Date: Mon, 4 Sep 2023 12:37:57 +0200	[thread overview]
Message-ID: <e1fa6315-5de1-e843-3022-7f3023b1e189@redhat.com> (raw)
In-Reply-To: <20230904082318.1465055-7-nrb@linux.ibm.com>

On 04/09/2023 10.22, Nico Boehr wrote:
> Sometimes, it is useful to share some defines between a snippet and a
> test. By adding the source directory to include paths, header files can
> be placed in the snippet directory and included from the test (or vice
> versa).
> 
> This is a prerequisite for "s390x: add a test for SIE without MSO/MSL".
> 
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
>   s390x/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/Makefile b/s390x/Makefile
> index 706be7920406..9d5c08339d16 100644
> --- a/s390x/Makefile
> +++ b/s390x/Makefile
> @@ -67,7 +67,7 @@ test_cases: $(tests)
>   test_cases_binary: $(tests_binary)
>   test_cases_pv: $(tests_pv_binary)
>   
> -INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x
> +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x $(SRCDIR)/s390x
>   # Include generated header files (e.g. in case of out-of-source builds)
>   INCLUDE_PATHS += lib
>   CPPFLAGS = $(addprefix -I,$(INCLUDE_PATHS))

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2023-09-04 10:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  8:22 [kvm-unit-tests PATCH v6 0/8] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 1/8] lib: s390x: introduce bitfield for PSW mask Nico Boehr
2023-09-04  9:49   ` Thomas Huth
2023-09-05 12:22   ` Janosch Frank
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 2/8] s390x: add function to set DAT mode for all interrupts Nico Boehr
2023-09-04  9:54   ` Thomas Huth
2023-09-05 12:26   ` Janosch Frank
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 3/8] s390x: sie: switch to home space mode before entering SIE Nico Boehr
2023-09-04  9:59   ` Thomas Huth
2023-09-04 11:07     ` Nico Boehr
2023-09-04 11:40       ` Thomas Huth
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 4/8] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 5/8] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 6/8] s390x: add test source dir to include paths Nico Boehr
2023-09-04 10:37   ` Thomas Huth [this message]
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 7/8] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-09-05 13:45   ` Janosch Frank
2023-09-04  8:22 ` [kvm-unit-tests PATCH v6 8/8] lib: s390x: interrupt: remove TEID_ASCE defines Nico Boehr
2023-09-04 10:39   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1fa6315-5de1-e843-3022-7f3023b1e189@redhat.com \
    --to=thuth@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox