From: Janosch Frank <frankja@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
mhartmay@linux.ibm.com, nsg@linux.ibm.com,
borntraeger@de.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v2 2/2] KVM: s390: pv: fix index value of replaced ASCE
Date: Wed, 12 Jul 2023 13:58:49 +0200 [thread overview]
Message-ID: <e3daf6b9-c7e9-89f3-b6ab-d8cf89de0b86@linux.ibm.com> (raw)
In-Reply-To: <20230705111937.33472-3-imbrenda@linux.ibm.com>
On 7/5/23 13:19, Claudio Imbrenda wrote:
> The index field of the struct page corresponding to a guest ASCE should
> be 0. When replacing the ASCE in s390_replace_asce(), the index of the
> new ASCE should also be set to 0.
>
> Having the wrong index might lead to the wrong addresses being passed
> around when notifying pte invalidations, and eventually to validity
> intercepts (VM crash) if the prefix gets unmapped and the notifier gets
> called with the wrong address.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
No fixes tag?
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2023-07-12 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:19 [PATCH v2 0/2] KVM: s390: pv: fix two small bugs Claudio Imbrenda
2023-07-05 11:19 ` [PATCH v2 1/2] KVM: s390: pv: simplify shutdown and fix race Claudio Imbrenda
2023-07-11 15:18 ` Nico Boehr
2023-07-05 11:19 ` [PATCH v2 2/2] KVM: s390: pv: fix index value of replaced ASCE Claudio Imbrenda
2023-07-11 14:12 ` Philippe Mathieu-Daudé
2023-07-11 14:31 ` Claudio Imbrenda
2023-07-12 11:58 ` Janosch Frank [this message]
2023-07-12 12:06 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3daf6b9-c7e9-89f3-b6ab-d8cf89de0b86@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox