From: David Hildenbrand <david@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, borntraeger@de.ibm.com, nrb@linux.ibm.com,
seiden@linux.ibm.com, nsg@linux.ibm.com,
schlameuss@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [PATCH v1 1/2] KVM: s390: fix issues when splitting folios
Date: Thu, 13 Feb 2025 21:17:10 +0100 [thread overview]
Message-ID: <e58310a9-0fd7-44fa-b66b-b98502dbed30@redhat.com> (raw)
In-Reply-To: <20250213200755.196832-2-imbrenda@linux.ibm.com>
> + struct folio *folio = page_folio(page);
> int rc;
>
> lockdep_assert_not_held(&mm->mmap_lock);
> @@ -2645,7 +2646,11 @@ int kvm_s390_wiggle_split_folio(struct mm_struct *mm, struct folio *folio, bool
> lru_add_drain_all();
> if (split) {
> folio_lock(folio);
> - rc = split_folio(folio);
> + rc = min_order_for_split(folio);
> + if (rc > 0)
> + rc = -EINVAL;
> + if (!rc)
> + rc = split_huge_page_to_list_to_order(page, NULL, 0);
split_huge_page() ?
But see my reply to #2. Likely we should just undo the refactorings you
added while moving the code.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-02-13 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:07 [PATCH v1 0/2] KVM: s390: fix two newly introduced bugs Claudio Imbrenda
2025-02-13 20:07 ` [PATCH v1 1/2] KVM: s390: fix issues when splitting folios Claudio Imbrenda
2025-02-13 20:17 ` David Hildenbrand [this message]
2025-02-14 9:43 ` Claudio Imbrenda
2025-02-13 20:07 ` [PATCH v1 2/2] KVM: s390: pv: fix race when making a page secure Claudio Imbrenda
2025-02-13 20:16 ` David Hildenbrand
2025-02-13 20:33 ` David Hildenbrand
2025-02-14 10:17 ` Claudio Imbrenda
2025-02-14 10:27 ` David Hildenbrand
2025-02-14 10:41 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e58310a9-0fd7-44fa-b66b-b98502dbed30@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
--cc=seiden@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox