From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Colin King <colin.king@canonical.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio/s390: add missing \n to end of dev_err message
Date: Wed, 28 Sep 2016 08:38:55 +0200 [thread overview]
Message-ID: <ec73622e-075f-a14b-0a6d-af07dc4d2d8b@de.ibm.com> (raw)
In-Reply-To: <20160927200844.16008-1-colin.king@canonical.com>
On 09/27/2016 10:08 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err message is missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/s390/virtio/virtio_ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index 8688ad4..9d36dc4 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -462,7 +462,7 @@ static void virtio_ccw_del_vq(struct virtqueue *vq, struct ccw1 *ccw)
> * This may happen on device detach.
> */
> if (ret && (ret != -ENODEV))
> - dev_warn(&vq->vdev->dev, "Error %d while deleting queue %d",
> + dev_warn(&vq->vdev->dev, "Error %d while deleting queue %d\n",
> ret, index);
>
> vring_del_virtqueue(vq);
>
Thanks, applied.
prev parent reply other threads:[~2016-09-28 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 20:08 [PATCH] virtio/s390: add missing \n to end of dev_err message Colin King
2016-09-28 6:38 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec73622e-075f-a14b-0a6d-af07dc4d2d8b@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=colin.king@canonical.com \
--cc=cornelia.huck@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox