public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Qiang <liqiang64@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <wenjia@linux.ibm.com>, <jaka@linux.ibm.com>,
	<alibuda@linux.alibaba.com>, <tonylu@linux.alibaba.com>,
	<guwen@linux.alibaba.com>, <linux-s390@vger.kernel.org>,
	<netdev@vger.kernel.org>, <luanjianhai@huawei.com>,
	<zhangxuzhou4@huawei.com>, <dengguangxing@huawei.com>,
	<gaochao24@huawei.com>
Subject: Re: [PATCH net-next] net/smc: Optimize the timing of unlocking in smc_listen_work
Date: Mon, 2 Dec 2024 10:20:41 +0800	[thread overview]
Message-ID: <ed04079e-2bd8-453b-9076-aabb6095d3e4@huawei.com> (raw)
In-Reply-To: <20241130110425.4610e6b6@kernel.org>



在 2024/12/1 3:04, Jakub Kicinski 写道:
> On Sat, 30 Nov 2024 16:26:30 +0800 liqiang wrote:
>> The optimized code is equivalent to the original process, and it releases the
>> lock early.
> 
> By a single clock cycle? You need to provide much more detailed
> justification, otherwise this looks like churn for no real gain.

I don't have any more information about this patch, I saw that
the lock will be released regardless of branch true or false,
so brought it forward.

Thanks for your reply, Jakub!
:)

-- 
Cheers,
Li Qiang


      reply	other threads:[~2024-12-02  2:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  8:26 [PATCH net-next] net/smc: Optimize the timing of unlocking in smc_listen_work liqiang
2024-11-30 19:04 ` Jakub Kicinski
2024-12-02  2:20   ` Li Qiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed04079e-2bd8-453b-9076-aabb6095d3e4@huawei.com \
    --to=liqiang64@huawei.com \
    --cc=alibuda@linux.alibaba.com \
    --cc=dengguangxing@huawei.com \
    --cc=gaochao24@huawei.com \
    --cc=guwen@linux.alibaba.com \
    --cc=jaka@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=luanjianhai@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=tonylu@linux.alibaba.com \
    --cc=wenjia@linux.ibm.com \
    --cc=zhangxuzhou4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox