From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Thomas Huth <thuth@redhat.com>, Nico Boehr <nrb@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/5] lib: Add pseudo random functions
Date: Wed, 13 Dec 2023 18:43:51 +0100 [thread overview]
Message-ID: <ed6b4a7188389617ffc85453e9270ffadd863a01.camel@linux.ibm.com> (raw)
In-Reply-To: <20231213-8407f7ddc3a972de2715db9c@orel>
On Wed, 2023-12-13 at 14:38 +0100, Andrew Jones wrote:
> On Wed, Dec 13, 2023 at 01:49:38PM +0100, Nina Schoetterl-Glausch wrote:
> > Add functions for generating pseudo random 32 and 64 bit values.
> > The implementation is very simple and the randomness likely not
> > of high quality.
[...]
> Alex Bennée posted a prng patch a long time ago that never got merged.
>
> https://www.spinics.net/lists/kvm-arm/msg50921.html
>
> would it be better to merge that?
Well, it's hard to say what metric to apply here.
How good does the randomness need to be?
I chose a minimal interface that should be amendable to evolution.
That's why the state is hidden behind a typedef.
I think this would be good for Alex' patch, too, and there is nothing gained
by exposing the implementation by prefixing everything with isaac.
My patch is also simpler to review.
But I'm certainly not opposed to better algorithms.
>
> Thanks,
> drew
next prev parent reply other threads:[~2023-12-13 17:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 12:49 [kvm-unit-tests PATCH 0/5] s390x: STFLE nested interpretation Nina Schoetterl-Glausch
2023-12-13 12:49 ` [kvm-unit-tests PATCH 1/5] lib: Add pseudo random functions Nina Schoetterl-Glausch
2023-12-13 13:38 ` Andrew Jones
2023-12-13 17:43 ` Nina Schoetterl-Glausch [this message]
2023-12-13 17:53 ` Andrew Jones
2023-12-13 12:49 ` [kvm-unit-tests PATCH 2/5] s390x: lib: Remove double include Nina Schoetterl-Glausch
2023-12-13 16:42 ` Claudio Imbrenda
2023-12-13 12:49 ` [kvm-unit-tests PATCH 3/5] s390x: Add library functions for exiting from snippet Nina Schoetterl-Glausch
2023-12-13 16:42 ` Claudio Imbrenda
2023-12-14 20:02 ` Nina Schoetterl-Glausch
2023-12-15 12:37 ` Claudio Imbrenda
2023-12-13 12:49 ` [kvm-unit-tests PATCH 4/5] s390x: Use library functions for snippet exit Nina Schoetterl-Glausch
2023-12-13 16:45 ` Claudio Imbrenda
2023-12-15 11:50 ` Nina Schoetterl-Glausch
2023-12-15 13:53 ` Claudio Imbrenda
2023-12-13 12:49 ` [kvm-unit-tests PATCH 5/5] s390x: Add test for STFLE interpretive execution (format-0) Nina Schoetterl-Glausch
2023-12-13 17:00 ` Claudio Imbrenda
2023-12-13 17:31 ` Nina Schoetterl-Glausch
2023-12-14 10:18 ` Nina Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6b4a7188389617ffc85453e9270ffadd863a01.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox