From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Christoph Schlameuss <schlameuss@linux.ibm.com>, kvm@vger.kernel.org
Cc: Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/6] KVM: s390: vsie: Remove duplicate assertion
Date: Fri, 7 Aug 2026 12:32:10 +0200 [thread overview]
Message-ID: <eea54688-da7f-420d-9b88-04384519572d@linux.ibm.com> (raw)
In-Reply-To: <20260807-vsie-cleanup-202607-v1-2-b18659b55e3d@linux.ibm.com>
Am 07.08.26 um 11:57 schrieb Christoph Schlameuss:
> This is covered by a static_assert at the struct vsie_page definition.
>
> Fixes: e38c884df921 ("KVM: s390: Switch to new gmap")
we could argue to remove this as this is likely not needed for stable
since its a build bug, but does not hurt.
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> ---
> arch/s390/kvm/vsie.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index eea24562e7db..3e956c7faa4b 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -1565,7 +1565,6 @@ int kvm_s390_handle_vsie(struct kvm_vcpu *vcpu)
> if (vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PSTATE)
> return kvm_s390_inject_program_int(vcpu, PGM_PRIVILEGED_OP);
>
> - BUILD_BUG_ON(sizeof(struct vsie_page) != PAGE_SIZE);
> scb_addr = kvm_s390_get_base_disp_s(vcpu, NULL);
>
> /* 512 byte alignment */
>
next prev parent reply other threads:[~2026-08-07 10:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 9:57 [PATCH 0/6] KVM: s390: vsie: Small VSIE cleanup and improvements Christoph Schlameuss
2026-08-07 9:57 ` [PATCH 1/6] KVM: s390: Remove double 64bscao feature check Christoph Schlameuss
2026-08-07 9:59 ` sashiko-bot
2026-08-07 10:59 ` Claudio Imbrenda
2026-08-07 9:57 ` [PATCH 2/6] KVM: s390: vsie: Remove duplicate assertion Christoph Schlameuss
2026-08-07 9:59 ` sashiko-bot
2026-08-07 10:32 ` Christian Borntraeger [this message]
2026-08-07 11:03 ` Claudio Imbrenda
2026-08-07 9:57 ` [PATCH 3/6] KVM: s390: vsie: Convert shift to phys_to_pfn() Christoph Schlameuss
2026-08-07 10:02 ` sashiko-bot
2026-08-07 10:36 ` Christian Borntraeger
2026-08-07 10:40 ` Sven Schnelle
2026-08-07 11:06 ` Sven Schnelle
2026-08-07 11:28 ` Claudio Imbrenda
2026-08-07 11:04 ` Claudio Imbrenda
2026-08-07 9:57 ` [PATCH 4/6] KVM: s390: vsie: Assert mcck_info offset in vsie_page Christoph Schlameuss
2026-08-07 10:02 ` sashiko-bot
2026-08-07 10:37 ` Christian Borntraeger
2026-08-07 9:57 ` [PATCH 5/6] KVM: s390: vsie: Assert crycb alignment " Christoph Schlameuss
2026-08-07 10:00 ` sashiko-bot
2026-08-07 10:38 ` Christian Borntraeger
2026-08-07 11:25 ` Claudio Imbrenda
2026-08-07 9:57 ` [PATCH 6/6] KVM: s390: vsie: Create constant SCB_ALIGNMENT_SHIFT Christoph Schlameuss
2026-08-07 10:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea54688-da7f-420d-9b88-04384519572d@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schlameuss@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox