From: Julian Wiedmann <jwi@linux.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
heiko.carstens@de.ibm.com, ubraun@linux.ibm.com
Subject: Re: [PATCH net] s390/qeth: support net namespaces for L3 devices
Date: Sat, 28 Mar 2020 11:34:07 +0100 [thread overview]
Message-ID: <f0db28f1-d1a2-7173-1ac7-123f514768b1@linux.ibm.com> (raw)
In-Reply-To: <20200327.153902.1896503128370913021.davem@davemloft.net>
On 27.03.20 23:39, David Miller wrote:
> From: Julian Wiedmann <jwi@linux.ibm.com>
> Date: Fri, 27 Mar 2020 12:00:42 +0100
>
>> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
>> devices that have been moved into a net namespace. We need to program
>> those IPs into the HW just as usual, otherwise inbound traffic won't
>> flow.
>>
>> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
>> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
>
> This looks more like a feature, openning the L3 driver into multiple
> namespaces, rather than a critical fix.
>
Definitely not 'critical', agreed. It's rather silly though that things
currently work just fine for IPv6, but not for IPv4.
Mind queueing this up for net-next then instead? Thanks.
next prev parent reply other threads:[~2020-03-28 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 11:00 [PATCH net] s390/qeth: support net namespaces for L3 devices Julian Wiedmann
2020-03-27 22:39 ` David Miller
2020-03-28 10:34 ` Julian Wiedmann [this message]
2020-03-30 5:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0db28f1-d1a2-7173-1ac7-123f514768b1@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox