From: Janosch Frank <frankja@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: thuth@redhat.com, kvm@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, nrb@linux.ibm.com, nsg@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v9 2/2] s390x: topology: Checking Configuration Topology Information
Date: Thu, 1 Jun 2023 11:38:37 +0200 [thread overview]
Message-ID: <fa415627-bfff-cc18-af94-cf55632973d5@linux.ibm.com> (raw)
In-Reply-To: <20230519112236.14332-3-pmorel@linux.ibm.com>
On 5/19/23 13:22, Pierre Morel wrote:
> STSI with function code 15 is used to store the CPU configuration
> topology.
>
> We retrieve the maximum nested level with SCLP and use the
> topology tree provided by the drawers, books, sockets, cores
> arguments.
>
> We check :
> - if the topology stored is coherent between the QEMU -smp
> parameters and kernel parameters.
> - the number of CPUs
> - the maximum number of CPUs
> - the number of containers of each levels for every STSI(15.1.x)
> instruction allowed by the machine.
> [topology]
> file = topology.elf
> +# 3 CPUs on socket 0 with different CPU TLE (standard, dedicated, origin)
> +# 1 CPU on socket 2
> +extra_params = -smp 1,drawers=3,books=3,sockets=4,cores=4,maxcpus=144 -cpu z14,ctop=on -device z14-s390x-cpu,core-id=1,entitlement=low -device z14-s390x-cpu,core-id=2,dedicated=on -device z14-s390x-cpu,core-id=10 -device z14-s390x-cpu,core-id=20 -device z14-s390x-cpu,core-id=130,socket-id=0,book-id=0,drawer-id=0 -append '-drawers 3 -books 3 -sockets 4 -cores 4'
> +
> +[topology-2]
> +file = topology.elf
> +extra_params = -smp 1,drawers=2,books=2,sockets=2,cores=30,maxcpus=240 -append '-drawers 2 -books 2 -sockets 2 -cores 30' -cpu z14,ctop=on -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=2,entitlement=low -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=3,entitlement=medium -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=4,entitlement=high -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=5,entitlement=high,dedicated=on -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=65,entitlement=low -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=66,entitlement=medium -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=67,entitlement=high -device z14-s390x-cpu,drawer-id=1,book-id=0,socket-id=0,core-id=68,entitlement=high,dedicated=on
Pardon my ignorance but I see z14 in there, will this work if we run on
a z13?
Also, will this work/fail gracefully if the test is run with a quemu
that doesn't know about topology or will it crash?
next prev parent reply other threads:[~2023-06-01 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 11:22 [kvm-unit-tests PATCH v9 0/2] S390x: CPU Topology Information Pierre Morel
2023-05-19 11:22 ` [kvm-unit-tests PATCH v9 1/2] s390x: topology: Check the Perform Topology Function Pierre Morel
2023-05-22 11:15 ` Nico Boehr
2023-05-22 15:17 ` Pierre Morel
2023-05-19 11:22 ` [kvm-unit-tests PATCH v9 2/2] s390x: topology: Checking Configuration Topology Information Pierre Morel
2023-06-01 9:38 ` Janosch Frank [this message]
2023-06-01 17:41 ` Pierre Morel
2023-06-02 7:50 ` Janosch Frank
2023-06-02 8:35 ` Nico Boehr
2023-06-02 9:03 ` Janosch Frank
2023-06-02 9:20 ` Thomas Huth
2023-06-02 10:02 ` Pierre Morel
2023-06-02 10:01 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa415627-bfff-cc18-af94-cf55632973d5@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox