Re: [PATCH v2 05/40] scsi: prepare for using 16-bits defined sense codes

[Hannes Reinecke <hare@suse.de>]

On 9/8/26 2:22 AM, Damien Le Moal wrote:
> On 9/7/26 21:16, Hannes Reinecke wrote:
>>> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
>>> index e321471e8ca2..11910142ac50 100644
>>> --- a/include/scsi/scsi_device.h
>>> +++ b/include/scsi/scsi_device.h
>>> @@ -518,6 +518,7 @@ extern void scsi_sanitize_inquiry_string(unsigned char
>>> *s, int len);
>>>     * to match any sense key, ASC, and ASCQ value.
>>>     */
>>>    #define SCMD_FAILURE_SENSE_KEY_ANY    0xff
>>> +#define SCMD_FAILURE_SENSE_CODE_ANY    0xffff
>>>    #define SCMD_FAILURE_ASC_ANY        0xff
>>>    #define SCMD_FAILURE_ASCQ_ANY        0xff
>>>    /* Always retry a matching failure. */
>>> @@ -526,8 +527,18 @@ extern void scsi_sanitize_inquiry_string(unsigned char
>>> *s, int len);
>>>    struct scsi_failure {
>>>        int result;
>>>        u8 sense_key;
>>> -    u8 asc;
>>> -    u8 ascq;
>>> +    union {
>>> +        struct {
>>> +#if defined(__BIG_ENDIAN)
>>> +            u8 asc;
>>> +            u8 ascq;
>>> +#elif defined(__LITTLE_ENDIAN)
>>> +            u8 ascq;
>>> +            u8 asc;
>>> +#endif
>>> +        };
>>> +        u16 sense_code;
>>> +    };
>>>        /*
>>>         * Number of times scsi_execute_cmd will retry the failure. It does
>>>         * not count for the total_allowed.
>>
>> Why do we have two definitions for the sense code header? Can't we combine it
>> with the definitions in scsi_common.h ?
> 
> This is *not* the sense header. This is the struct used to filter errors for
> internal SCSI commands issued with scsi_execute_cmd(). And since that function
> is devlared in scsi_device.h, this struct declaration is here too.
> 
Oh, I know. I just thought we could combine them.
But if not that's fine, too.

Reviewed-by: Hannes Reinecke <hare@kernel.org>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich