From: Janosch Frank <frankja@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: fix cc for successful PQAP
Date: Fri, 8 Dec 2023 11:31:58 +0100 [thread overview]
Message-ID: <fe3082f7-70fd-479f-b6a2-d753d271d6d5@linux.ibm.com> (raw)
In-Reply-To: <20231201181657.1614645-1-farman@linux.ibm.com>
On 12/1/23 19:16, Eric Farman wrote:
> The various errors that are possible when processing a PQAP
> instruction (the absence of a driver hook, an error FROM that
> hook), all correctly set the PSW condition code to 3. But if
> that processing works successfully, CC0 needs to be set to
> convey that everything was fine.
>
> Fix the check so that the guest can examine the condition code
> to determine whether GPR1 has meaningful data.
>
Hey Eric, I have yet to see this produce a fail in my AP KVM unit tests.
If you find some spare time I'd like to discuss how I can extend my test
so that I can see the fail before it's fixed.
next prev parent reply other threads:[~2023-12-08 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 18:16 [PATCH] KVM: s390: fix cc for successful PQAP Eric Farman
2023-12-04 11:48 ` Halil Pasic
2023-12-07 15:39 ` Anthony Krowiak
2023-12-07 16:11 ` Eric Farman
2023-12-07 20:31 ` Anthony Krowiak
2023-12-08 10:31 ` Janosch Frank [this message]
2023-12-08 11:24 ` Eric Farman
2023-12-08 14:21 ` Anthony Krowiak
2023-12-13 12:43 ` Eric Farman
2024-01-03 15:26 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3082f7-70fd-479f-b6a2-d753d271d6d5@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox