From: Stefan Haberland <sth@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>,
Jan Hoeppner <hoeppner@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/dasd: avoid calling do_gettimeofday()
Date: Wed, 8 Nov 2017 14:27:39 +0100 [thread overview]
Message-ID: <ffe1ebfd-36d3-3408-429f-76aceec04055@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171106140328.1498644-1-arnd@arndb.de>
On 06.11.2017 15:02, Arnd Bergmann wrote:
> do_gettimeofday() is deprecated because it's not y2038-safe on
> 32-bit architectures. Since it is basically a wrapper around
> ktime_get_real_ts64(), we can just call that function directly
> instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/s390/block/dasd_eer.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eer.c b/drivers/s390/block/dasd_eer.c
> index 4630782b5456..5169c717c9d6 100644
> --- a/drivers/s390/block/dasd_eer.c
> +++ b/drivers/s390/block/dasd_eer.c
> @@ -296,7 +296,7 @@ static void dasd_eer_write_standard_trigger(struct dasd_device *device,
> {
> struct dasd_ccw_req *temp_cqr;
> int data_size;
> - struct timeval tv;
> + struct timespec64 ts64;
...
> + ktime_get_real_ts64(&ts);
> + header.tv_sec = ts.tv_sec;
> + header.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
>
I renamed ts64 to ts to match the usage below and fix the compile error.
Beside of this, applied. Thanks for the patch.
next prev parent reply other threads:[~2017-11-08 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:02 [PATCH] s390/dasd: avoid calling do_gettimeofday() Arnd Bergmann
2017-11-08 13:27 ` Stefan Haberland [this message]
2017-11-08 13:56 ` Arnd Bergmann
2017-11-08 15:47 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffe1ebfd-36d3-3408-429f-76aceec04055@linux.vnet.ibm.com \
--to=sth@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox