From: Andreas Schwab <schwab@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] partitions: fix build error in ibm partition detection code
Date: Thu, 12 Aug 2010 10:53:38 +0200 [thread overview]
Message-ID: <m31va4nre5.fsf@hase.home> (raw)
In-Reply-To: <20100812083104.GC7814@osiris.boeblingen.de.ibm.com> (Heiko Carstens's message of "Thu, 12 Aug 2010 10:31:04 +0200")
Heiko Carstens <heiko.carstens@de.ibm.com> writes:
> - strlcat(tmp, sizeof(tmp), "(nonl)", PAGE_SIZE);
> + snprintf(tmp, sizeof(tmp), "(nonl)");
> + strlcat(state->pp_buf, tmp, PAGE_SIZE);
What's the point of tmp and snprintf if it just creates a copy of a
constant string?
strlcat(state->pp_buf, "(nonl)", PAGE_SIZE);
Andreas.
--
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
next prev parent reply other threads:[~2010-08-12 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 8:31 [PATCH] partitions: fix build error in ibm partition detection code Heiko Carstens
2010-08-12 8:53 ` Andreas Schwab [this message]
2010-08-12 10:44 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31va4nre5.fsf@hase.home \
--to=schwab@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox