Re: [PATCH v8 10/15] s390/vfio-ap: Add method to set a new guest AP configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] vfio_ap: duplicate prototype for vfio_ap_matrix_init()
--

commit e05cec73b2479bdf6aa3c63debaa31756d289ed2
Author: Anthony Krowiak <akrowiak@linux.ibm.com>

s390/vfio-ap: Add method to set a new guest AP configuration

This patch adds a new vfio_ap_set_new_config function to set a guest's AP
configuration. It refactors code from the ap_config_store function into a
new, non-static function which is callable from both the sysfs attribute
handler and the live guest migration code.

> diff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h
> index 9044ef4408c87..3910b5c023c91 100644
> --- a/drivers/s390/crypto/vfio_ap_private.h
> +++ b/drivers/s390/crypto/vfio_ap_private.h
> @@ -172,6 +172,8 @@ void vfio_ap_on_cfg_changed(struct ap_config_info *new_config_info,
>  void vfio_ap_on_scan_complete(struct ap_config_info *new_config_info,
>  			      struct ap_config_info *old_config_info);
>  
> +void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix);

[Severity: Low]
This isn't a bug, but does this patch add a duplicate prototype for
vfio_ap_matrix_init()? Looking further down in this header, the exact same
declaration already exists just above the newly added
vfio_ap_set_new_guest_config() prototype.

> +
>  void vfio_ap_init_migration_capabilities(struct ap_matrix_mdev *matrix_mdev);

[ ... ]

> @@ -235,4 +237,7 @@ assert_has_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
>  
>  void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix);
>  
> +int vfio_ap_set_new_guest_config(struct ap_matrix_mdev *matrix_mdev,
> +				 struct ap_matrix *m_new);
> +
>  #endif /* _VFIO_AP_PRIVATE_H_ */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009114244.1213173-1-akrowiak@linux.ibm.com?part=10