Re: [PATCH v1 10/10] KVM: s390: Enable 1M pages by default

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] KVM: s390: missing kernel-parameters.txt update for kvm.hpage default change
--

commit fecb3f4de4d4ce9912b0cacb3dd61c76a521ab9f
Author: Claudio Imbrenda <imbrenda@linux.ibm.com>

KVM: s390: Enable 1M pages by default

This commit changes the default value of the kvm.hpage module parameter on
s390 from 0 to 1 so that 1m hugepages are used by default for guest mappings
when userspace uses hugepages.

> diff --git a/arch/s390/kvm/s390/s390.c b/arch/s390/kvm/s390/s390.c
> index 280310870dac3..71d79b4437ac0 100644
> --- a/arch/s390/kvm/s390/s390.c
> +++ b/arch/s390/kvm/s390/s390.c
> @@ -212,7 +212,7 @@ module_param(nested, int, S_IRUGO);
>  MODULE_PARM_DESC(nested, "Nested virtualization support");
>  
>  /* allow 1m huge page guest backing */
> -static int hpage;
> +static int hpage = 1;
>  module_param(hpage, int, 0444);
>  MODULE_PARM_DESC(hpage, "1m huge page backing support");
>  

[Severity: Low]
In arch/s390/kvm/s390/s390.c, hpage is exposed as a kernel command-line and
module parameter (kvm.hpage=) via module_param(hpage, int, 0444), and its
default value is changed here from 0 to 1.

Should this change also update Documentation/admin-guide/kernel-parameters.txt
to document kvm.hpage= (its format, behavior, default value, and s390
architecture applicability), as well as the s390x nested virtualization
section in Documentation/virt/kvm/x86/running-nested-guests.rst?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022155531.204593-1-imbrenda@linux.ibm.com?part=10