Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Omar Elghoul" <oelghoul@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v11 1/5] s390/pci: Hold fmb_lock when enabling or disabling PCI devices
Date: Wed, 28 Oct 2026 15:54:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-188101@kernel.org> (raw)
In-Reply-To: <20261028154352.15108-2-oelghoul@linux.ibm.com>

> Ensure that fmb_lock is held by pcibios_enable_device() and
> pcibios_disable_device() when calling zpci_fmb_enable_device() or
> zpci_fmb_disable_device(), respectively. Additionally, assert that the
> fmb_lock is held within the latter two functions to prevent future race
> conditions regarding new callers.
> 
> Fixes: af0a8a8453f7 ("s390/pci: implement pcibios_add_device")
> Fixes: 944239c59e93 ("s390/pci: implement pcibios_release_device")
> Cc: stable@vger.kernel.org
> Signed-off-by: Omar Elghoul <oelghoul@linux.ibm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028154352.15108-1-oelghoul@linux.ibm.com?part=1


  reply	other threads:[~2026-10-28 15:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 15:43 [PATCH v11 0/5] vfio-pci/zdev: Improved zPCI Function Measurement Support Omar Elghoul
2026-10-28 15:43 ` [PATCH v11 1/5] s390/pci: Hold fmb_lock when enabling or disabling PCI devices Omar Elghoul
2026-10-28 15:54   ` sashiko-bot [this message]
2026-10-28 15:43 ` [PATCH v11 2/5] s390/pci: Improve function measurement state management Omar Elghoul
2026-10-28 15:57   ` sashiko-bot
2026-10-28 21:05   ` Niklas Schnelle
2026-10-28 15:43 ` [PATCH v11 3/5] s390/pci: Reuse FMB buffer across enable and disable cycles Omar Elghoul
2026-10-28 15:59   ` sashiko-bot
2026-10-28 16:15     ` Omar Elghoul
2026-10-28 21:12       ` Niklas Schnelle
2026-10-29 12:27         ` Omar Elghoul
2026-10-28 15:43 ` [PATCH v11 4/5] s390/pci: Fence FMB enable/disable via debugfs for passthrough devices Omar Elghoul
2026-10-28 15:47   ` sashiko-bot
2026-10-28 15:43 ` [PATCH v11 5/5] vfio-pci/zdev: Add VFIO FMB device features Omar Elghoul
2026-10-28 15:59   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-188101@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=oelghoul@linux.ibm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox