Re: [PATCH V2] x86/entry: Fix ptrace regression

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] x86/entry: unmatched opening brace in do_syscall_32_irqs_on() breaks build
--

commit b8945a5f45d9b3a8ab21f8b9c553fa0b34f2a69f
Author: Thomas Gleixner <tglx@kernel.org>

x86/entry: Fix ptrace regression

This commit restores the historic syscall entry behavior where syscall
number -1L keeps tracer modifications to regs->ax while other invalid
syscall numbers overwrite regs->ax with -ENOSYS.

> diff --git a/arch/x86/entry/syscall_32.c b/arch/x86/entry/syscall_32.c
> index a59509bb460ab..e409de28445f9 100644
> --- a/arch/x86/entry/syscall_32.c
> +++ b/arch/x86/entry/syscall_32.c
> @@ -77,6 +77,10 @@ static __always_inline void do_syscall_32_irqs_on(struct pt_regs *regs, unsigned
>  	if (likely(nr < IA32_NR_syscalls)) {
>  		nr = array_index_nospec(nr, IA32_NR_syscalls);
>  		regs->ax = ia32_sys_call(regs, (unsigned int)nr);
> +	} else {
> +		/* See comment in do_syscall_64() */
> +		if (nr != -1UL) {
> +			regs->ax = -ENOSYS;
>  	}
>  }

[Severity: High]
Does the inner if (nr != -1UL) statement in do_syscall_32_irqs_on() have an
unmatched opening brace that leaves the function unclosed and breaks the
build when CONFIG_X86_32 or CONFIG_IA32_EMULATION is enabled?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/87ecd4xwlr.ffs@fw13?part=1