From: sashiko-bot@kernel.org
To: "Omar Elghoul" <oelghoul@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v12 2/5] s390/pci: Improve function measurement state management
Date: Tue, 03 Nov 2026 15:17:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-195579@kernel.org> (raw)
In-Reply-To: <20261103150114.68873-3-oelghoul@linux.ibm.com>
> When a zPCI function is disabled and re-enabled, the firmware implicitly
> disables function measurement while the kernel still believes it is
> enabled, leading to a disconnect between the user-visible state and the
> actual device state.
>
> Add the statistics_on field to struct zpci_dev to track the desired FMB
> state. Introduce the functions zpci_fmb_request_on()/_off(), which defer
> to zpci_fmb_enable()/_disable() to perform the actual firmware change.
> This decouples the enablement or disablement step from managing the
> user's requested state.
>
> Restore the state in pcibios_enable_device(), pcibios_disable_device(),
> and zpci_reenable_device(). New devices start with measurement on by
> default, unchanged from before.
>
> Signed-off-by: Omar Elghoul <oelghoul@linux.ibm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103150114.68873-1-oelghoul@linux.ibm.com?part=2
next prev parent reply other threads:[~2026-11-03 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 15:01 [PATCH v12 0/5] vfio-pci/zdev: Improved zPCI Function Measurement Support Omar Elghoul
2026-11-03 15:01 ` [PATCH v12 1/5] s390/pci: Hold fmb_lock when enabling or disabling PCI devices Omar Elghoul
2026-11-03 15:09 ` sashiko-bot
2026-11-03 15:01 ` [PATCH v12 2/5] s390/pci: Improve function measurement state management Omar Elghoul
2026-11-03 15:17 ` sashiko-bot [this message]
2026-11-03 15:01 ` [PATCH v12 3/5] s390/pci: Improve FMB memory management Omar Elghoul
2026-11-03 15:15 ` sashiko-bot
2026-11-03 21:32 ` Niklas Schnelle
2026-11-03 15:01 ` [PATCH v12 4/5] s390/pci: Fence FMB enable/disable via debugfs for passthrough devices Omar Elghoul
2026-11-03 15:07 ` sashiko-bot
2026-11-03 15:01 ` [PATCH v12 5/5] vfio-pci/zdev: Add VFIO FMB device features Omar Elghoul
2026-11-03 15:08 ` sashiko-bot
2026-11-03 21:08 ` Niklas Schnelle
2026-11-03 22:45 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195579@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=oelghoul@linux.ibm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox