From: sashiko-bot@kernel.org
To: "Andreas Grapentin" <gra@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] KVM: s390: arm64: Tolerate unused functions in extracted source
Date: Thu, 05 Nov 2026 14:19:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-199220@kernel.org> (raw)
In-Reply-To: <20261105-series1-fixups2-v1-1-55f59e6c4c7b@linux.ibm.com>
> Extracting static declared arm64 functions with no consumer on the s390
> side into the generated sources causes compiler warnings when subsuming
> the generated sources from s390. This causes spurious compiler warnings
> that make it harder to extract larger, more cohesive portions of the
> arm64 source.
>
> Update the extraction logic to wrap the extracted source into diagnostic
> pragmas to disable -Wunused-function for the extracted block. This
> allows us to share more freely, and also opens up more paths for future
> code sharing with a separation of extraction and definition of consumers
> in separate commits.
>
> Obviously no functional change intended.
>
> Signed-off-by: Andreas Grapentin <gra@linux.ibm.com>
> Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-series1-fixups2-v1-1-55f59e6c4c7b@linux.ibm.com?part=1
prev parent reply other threads:[~2026-11-05 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:14 [PATCH] KVM: s390: arm64: Tolerate unused functions in extracted source Andreas Grapentin
2026-11-05 14:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-199220@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gra@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox