From: sashiko-bot@kernel.org
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 14/15] lib/lz4: replace lz4_kernel_api.h's prototypes with <linux/lz4.h>
Date: Fri, 06 Nov 2026 14:51:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-201619@kernel.org> (raw)
In-Reply-To: <20261106-lz4-vendor-upstream-v2-14-ee04c3f0d7dc@samsung.com>
> lz4_kernel_api.h carried its own copy of the twenty public prototypes
> because it could not include <linux/lz4.h>, which defined the stream
> types that upstream's headers also define.
>
> The types are incomplete now, so it can. Two prototype lists for one
> ABI is a drift hazard: the entry points were built against one and their
> callers against the other, so no compiler ever saw both, and MODVERSIONS
> would not catch a mismatch either, since it hashes the exporter's view
> only. Now there is one list.
>
> It also puts the public constants in scope of the entry points, so the
> size assertions can name them, and the HC level clamp can use
> LZ4HC_CLAMP_CLEVEL, static_asserted equal to upstream's
> LZ4HC_CLEVEL_OPT_MIN.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-lz4-vendor-upstream-v2-0-ee04c3f0d7dc@samsung.com?part=14
next prev parent reply other threads:[~2026-11-06 14:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261106144247eucas1p15bdd0704f32d1cb3b19f9d2296a0cbc3@eucas1p1.samsung.com>
2026-11-06 14:42 ` [PATCH v2 00/15] lib/lz4: stop forking upstream LZ4, vendor it instead Michal Wilczynski
2026-11-06 14:42 ` [PATCH v2 01/15] lib/decompress_unlz4: use LZ4_decompress_safe_partial() before boot Michal Wilczynski
2026-11-06 14:59 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 02/15] lib/lz4: remove LZ4_decompress_fast() and its variants Michal Wilczynski
2026-11-06 14:47 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 03/15] zram: lz4hc: reset the dictionary stream once, not per page Michal Wilczynski
2026-11-06 14:49 ` sashiko-bot
2026-11-10 5:31 ` Sergey Senozhatsky
2026-11-06 14:42 ` [PATCH v2 04/15] lib/lz4: import upstream LZ4 sources verbatim Michal Wilczynski
2026-11-06 14:48 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 05/15] lib/lz4: backport upstream's -Wmissing-prototypes fix Michal Wilczynski
2026-11-06 14:46 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 06/15] lib/lz4: backport upstream's aarch64 fast decode loop enablement Michal Wilczynski
2026-11-06 14:47 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 07/15] lib/lz4: backport upstream's match length limit fix Michal Wilczynski
2026-11-06 14:50 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 08/15] lib/lz4: add the build environment for the vendored sources Michal Wilczynski
2026-11-06 14:57 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 09/15] arch: boot: put the LZ4 freestanding headers on the decompressor path Michal Wilczynski
2026-11-06 14:49 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 10/15] lib/lz4: switch the compressor to the vendored sources Michal Wilczynski
2026-11-06 14:52 ` sashiko-bot
2026-11-10 5:36 ` Sergey Senozhatsky
2026-11-06 14:42 ` [PATCH v2 11/15] lib/lz4: switch the HC " Michal Wilczynski
2026-11-06 14:54 ` sashiko-bot
2026-11-06 14:42 ` [PATCH v2 12/15] lib/lz4: widen LZ4_DECOMPRESS_INPLACE_MARGIN for the fast decode loop Michal Wilczynski
2026-11-06 14:52 ` sashiko-bot
2026-11-11 22:02 ` Gao Xiang
2026-11-06 14:42 ` [PATCH v2 13/15] lib/lz4: switch the decompressor to the vendored sources Michal Wilczynski
2026-11-06 14:57 ` sashiko-bot
2026-11-10 5:39 ` Sergey Senozhatsky
2026-11-06 14:42 ` [PATCH v2 14/15] lib/lz4: replace lz4_kernel_api.h's prototypes with <linux/lz4.h> Michal Wilczynski
2026-11-06 14:51 ` sashiko-bot [this message]
2026-11-06 14:42 ` [PATCH v2 15/15] MAINTAINERS: add an entry for the LZ4 compression library Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201619@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox