Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH 3/5] s390/vmlogrdr: Replace get_zeroed_page() with kzalloc()
Date: Mon, 09 Nov 2026 08:54:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-204631@kernel.org> (raw)
In-Reply-To: <20261108-s390-char-ready-v1-3-3db507722530@kernel.org>

> vmlogrdr_init() allocates the buffers used to receive z/VM system
> service records via IUCV.
> 
> These buffers can be allocated with kmalloc() as there's nothing special
> about them to go directly to the page allocator.
> 
> kmalloc() provides a better API that does not require ugly casts and
> kfree() does not need to know the size of the freed object.
> 
> Performance difference between kmalloc() and __get_free_pages() is not
> measurable as both allocators take an object/page from a per-CPU list for
> fast path allocations.
> 
> For the slow path the performance is anyway determined by the amount of
> reclaim involved rather than by what allocator is used.
> 
> Replace use of get_zeroed_page() with kzalloc() and free_page() with
> kfree().
> 
> Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-s390-char-ready-v1-0-3db507722530@kernel.org?part=3


  reply	other threads:[~2026-11-09  8:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  8:48 [PATCH 0/5] s390/char: replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-08  8:48 ` [PATCH 1/5] s390/zcore: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-09  8:54   ` sashiko-bot
2026-11-08  8:48 ` [PATCH 2/5] s390/vmur: " Mike Rapoport (Microsoft)
2026-11-09  8:54   ` sashiko-bot
2026-11-08  8:49 ` [PATCH 3/5] s390/vmlogrdr: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  8:54   ` sashiko-bot [this message]
2026-11-08  8:49 ` [PATCH 4/5] s390/uvdevice: " Mike Rapoport (Microsoft)
2026-11-09  8:54   ` sashiko-bot
2026-11-08  8:49 ` [PATCH 5/5] s390/hmcdrv: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-09  8:54   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-204631@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox