From: sashiko-bot@kernel.org
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Baoquan He" <baoquan.he@linux.dev>,
"Borislav Petkov" <bp@alien8.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Helge Deller" <deller@gmx.de>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Rich Felker" <dalias@libc.org>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@kernel.org>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Will Deacon" <will@kernel.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
x86@kernel.org
Cc: "Alexandre Ghiti" <alex@ghiti.fr>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Cong Wang" <cwang@multikernel.io>,
"Mark Rutland" <mark.rutland@arm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"WANG Xuerui" <kernel@xen0n.name>,
kexec@lists.infradead.org, linux-m68k@lists.linux-m68k.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/2] arch, kexec: declare kexec and crash capabilities in Kconfig.kexec
Date: Thu, 19 Nov 2026 06:21:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-222519@kernel.org> (raw)
In-Reply-To: <20261119-arch-kconfig-v1-2-37c276fe4d26@kernel.org>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] riscv: missing ARCH_KEEP_MEMBLOCK and HOTPLUG_CPU selects for
KEXEC_FILE [1]
--
commit 72fcff7ceb4b8dc27b8490a2ed5edc55973e96f8
Author: Mike Rapoport (Microsoft) <rppt@kernel.org>
arch, kexec: declare kexec and crash capabilities in Kconfig.kexec
This commit moves the architecture capability options for kexec and crash
dumps into kernel/Kconfig.kexec and updates each architecture to select
them.
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index e7891a2a89da6..3fc73c99d06f1 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
[ ... ]
> @@ -65,9 +67,14 @@ config RISCV
> select ARCH_STACKWALK
> select ARCH_SUPPORTS_ATOMIC_RMW
> select ARCH_SUPPORTS_CFI
> + select ARCH_SUPPORTS_CRASH_DUMP
> + select ARCH_SUPPORTS_CRASH_HOTPLUG
> select ARCH_SUPPORTS_DEBUG_PAGEALLOC if MMU
> select ARCH_SUPPORTS_HUGE_PFNMAP if TRANSPARENT_HUGEPAGE
> select ARCH_SUPPORTS_HUGETLBFS if MMU
> + select ARCH_SUPPORTS_KEXEC
> + select ARCH_SUPPORTS_KEXEC_FILE if 64BIT
> + select ARCH_SUPPORTS_KEXEC_PURGATORY if 64BIT
> select ARCH_SUPPORTS_LTO_CLANG if CMODEL_MEDANY
> select ARCH_SUPPORTS_LTO_CLANG_THIN
> select ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS if 64BIT && MMU
> @@ -1105,38 +1112,17 @@ config RISCV_BOOT_SPINWAIT
>
> If unsure what to do here, say N.
>
> -config ARCH_SUPPORTS_KEXEC
> - def_bool y
> -
> config ARCH_SELECTS_KEXEC
> def_bool y
> depends on KEXEC
> select HOTPLUG_CPU if SMP
>
> -config ARCH_SUPPORTS_KEXEC_FILE
> - def_bool 64BIT
> -
> config ARCH_SELECTS_KEXEC_FILE
> def_bool y
> depends on KEXEC_FILE
> select HAVE_IMA_KEXEC if IMA
> select KEXEC_ELF
[Severity: High]
This problem wasn't introduced by this patch, but should KEXEC_FILE (or
KEXEC_CORE) also select ARCH_KEEP_MEMBLOCK and HOTPLUG_CPU if SMP
[1]?
config RISCV only has "select ARCH_KEEP_MEMBLOCK if ACPI || KEXEC", and
only ARCH_SELECTS_KEXEC selects HOTPLUG_CPU if SMP. When KEXEC_FILE=y and
KEXEC=n:
- Without ACPI, memblock_discard() frees the reserved regions array before
reserve_memblock_reserved_regions() registers them in iomem_resource, so
kexec_file_load() can place kexec segments over reserved memory.
- On SMP without another option enabling HOTPLUG_CPU,
smp_shutdown_nonboot_cpus() in machine_shutdown() and
cpu_ops_sbi.cpu_stop are compiled out, leaving secondary harts running
in the old kernel during kernel_kexec().
[1] https://sashiko.dev/#/bug/linux-78e86ad1-8753-462c-a044-1d3b3f2cab21
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-arch-kconfig-v1-0-37c276fe4d26@kernel.org?part=2
next prev parent reply other threads:[~2026-11-19 6:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 6:16 [PATCH 0/2] arch, kexec: declare kexec and crash capabilities in Kconfig.kexec Mike Rapoport (Microsoft)
2026-11-19 6:16 ` [PATCH 1/2] MAINTAINERS: add kernel/Kconfig.kexec to KEXEC Mike Rapoport (Microsoft)
2026-11-19 7:41 ` Baoquan He
2026-11-19 6:16 ` [PATCH 2/2] arch, kexec: declare kexec and crash capabilities in Kconfig.kexec Mike Rapoport (Microsoft)
2026-11-19 6:21 ` sashiko-bot [this message]
2026-11-19 7:29 ` Geert Uytterhoeven
2026-11-19 8:03 ` Heiko Carstens
2026-11-19 11:01 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222519@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=baoquan.he@linux.dev \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=cwang@multikernel.io \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasha.tatashin@soleen.com \
--cc=pjw@kernel.org \
--cc=pratyush@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sshegde@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox