From: sashiko-bot@kernel.org
To: "Mahanta Jambigi" <mjambigi@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net-next] net/smc: validate smc_diag_req length before reading diag_ext
Date: Fri, 20 Nov 2026 11:40:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-225085@kernel.org> (raw)
In-Reply-To: <20261120113708.3950966-1-mjambigi@linux.ibm.com>
> __sock_diag_cmd() only validates nlmsg_len against sizeof(struct
> sock_diag_req) (2 bytes). smc_diag_handler_dump() schedules a dump
> without a further check, so the dump path reads diag_ext at offset 3 of
> struct smc_diag_req from uninitialised skb tailroom. Add the missing
> nlmsg_len guard, matching every other sock_diag handler.
>
> Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120113708.3950966-1-mjambigi@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-11-20 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:37 [PATCH net-next] net/smc: validate smc_diag_req length before reading diag_ext Mahanta Jambigi
2026-11-20 11:40 ` sashiko-bot [this message]
2026-11-20 11:43 ` netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225085@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox