Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "André Almeida" <andrealmeid@igalia.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Arnd Bergmanon" <arnd@arndb.de>
Cc: "Christian Brauner" <brauner@kernel.org>,
	linux-kbuild@vger.kernel.org, kernel-dev@igalia.com,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	linux-perf-users@vger.kernel.org,
	"Ingo Molnar" <mingo@redhat.com>,
	"Magnus Lindholm" <linmag7@gmail.com>,
	nathan@kernel.org, nsc@kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v10 02/16] syscalls: Create unified partial table for all archs
Date: Fri, 20 Nov 2026 20:23:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-226043@kernel.org> (raw)
In-Reply-To: <20261119-tonyk-syscall_table-v10-2-a7c9ebd900f6@igalia.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] syscalls: inaccurate comments for ABI names and emit_nr()
  parameter order
--

commit c623dfa13f12a7f67002b068bc004d808cd6477b
Author: André Almeida <andrealmeid@igalia.com>

syscalls: Create unified partial table for all archs

This commit adds scripts/syscall_common.tbl for syscall numbers shared across
architectures and updates scripts/syscallhdr.sh and scripts/syscalltbl.sh to
accept a --common-tbl option.

> diff --git a/scripts/syscall_common.tbl b/scripts/syscall_common.tbl
> new file mode 100644
> index 0000000000000..8085030eb869e
> --- /dev/null
> +++ b/scripts/syscall_common.tbl
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
> +#
> +# syscall numbers shared by all architectures
> +#
> +# The format is:
> +# <number> <abi> <name> <entry point> [<compat entry point> [noreturn]]
> +#
> +# The abi can be "32", "clone3", "__cln3" and "memfd_secret"
> +#
> +# clone3 stands for the common clone3 entry, used by most archs. Some archs have
> +# their special entry and should use "__clone3".

[ ... ]

> diff --git a/scripts/syscallhdr.sh b/scripts/syscallhdr.sh
> index bad1ab606a0fb..8f7dfcf19a4c5 100755
> --- a/scripts/syscallhdr.sh
> +++ b/scripts/syscallhdr.sh

[ ... ]

> @@ -69,13 +76,35 @@ guard=_UAPI_ASM_$(basename "$outfile" |
>  	sed -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \
>  	-e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g')
>  
> -grep -E "^[0-9A-Fa-fXx]+[[:space:]]+$abis" "$infile" | {
> +emit_start_guard() {
>  	echo "#ifndef $guard"
>  	echo "#define $guard"
>  	echo
> +}
> +
> +# emit_nr(prefix, nr)
> +emit_nr() {
> +	local nr=$1
> +	local prefix=$2

[Severity: Low]
In scripts/syscall_common.tbl, the header comment lists "__cln3" instead of
"__clone3" and omits the "common" ABI used by most entries in the table.
Also, in scripts/syscallhdr.sh, the comment above emit_nr() documents the
arguments as (prefix, nr), whereas emit_nr() takes nr as $1 and prefix as $2.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-tonyk-syscall_table-v10-0-a7c9ebd900f6@igalia.com?part=2

  reply	other threads:[~2026-11-20 20:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 20:21 [PATCH v10 00/16] syscalls: Add a shared table for all archs André Almeida
2026-11-19 20:21 ` [PATCH v10 01/16] syscalls: Make --abis parsing more robust André Almeida
2026-11-19 20:21 ` [PATCH v10 02/16] syscalls: Create unified partial table for all archs André Almeida
2026-11-20 20:23   ` sashiko-bot [this message]
2026-11-19 20:21 ` [PATCH v10 03/16] scripts/syscall.tbl: Use the common table André Almeida
2026-11-19 20:21 ` [PATCH v10 04/16] s390: Use the common syscall table André Almeida
2026-11-19 20:21 ` [PATCH v10 05/16] sparc: " André Almeida
2026-11-19 20:21 ` [PATCH v10 06/16] mips: Remove duplicated syscallnr.sh André Almeida
2026-11-19 20:21 ` [PATCH v10 07/16] mips: Get rid of custom mips ABIs for syscall tables André Almeida
2026-11-19 20:21 ` [PATCH v10 08/16] mips: Use the common syscall table André Almeida
2026-11-19 20:21 ` [PATCH v10 09/16] syscalls: Add an option for offsetting the common table André Almeida
2026-11-19 20:22 ` [PATCH v10 10/16] alpha: Define entry point for set_mempolicy_home_node syscall André Almeida
2026-11-19 20:22 ` [PATCH v10 11/16] alpha: Use the common syscall table André Almeida
2026-11-19 20:22 ` [PATCH v10 12/16] syscalls: Avoid matching substrings in the ABI parsing André Almeida
2026-11-20 20:23   ` sashiko-bot
2026-11-19 20:22 ` [PATCH v10 13/16] arm: Reorganize syscall table and separated the ABIs André Almeida
2026-11-19 20:22 ` [PATCH v10 14/16] arm: Use common syscall table André Almeida
2026-11-19 20:22 ` [PATCH v10 15/16] perf: Add an option for common table for build_tables() André Almeida
2026-11-19 20:22 ` [PATCH v10 16/16] perf: Synchronize syscall tables with shared table André Almeida
2026-11-20 20:23   ` sashiko-bot
2026-11-20 20:23 ` [PATCH v10 00/16] syscalls: Add a shared table for all archs sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226043@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=borntraeger@linux.ibm.com \
    --cc=brauner@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kernel-dev@igalia.com \
    --cc=linmag7@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sparclinux@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox