Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nicolas Schier" <nsc@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Sasha Levin" <sashal@kernel.org>
Cc: "Harald Freudenberger" <freude@linux.ibm.com>,
	"Holger Dengler" <dengler@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"WANG Xuerui" <kernel@xen0n.name>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	linux-kbuild@vger.kernel.org, linux-s390@vger.kernel.org,
	"kernelci.org bot" <bot@kernelci.org>,
	"Nicolas Schier" <n.schier@fritz.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] Move struct cpu_feature to a <linux/device-id/cpu_feature.h>
Date: Sat, 21 Nov 2026 20:27:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-227340@kernel.org> (raw)
In-Reply-To: <20261120202712.3377691-1-nsc@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] s390/pkey: build failure in pkey_cca.c and pkey_ep11.c due to
  missing ap.h
--

commit 543ef19435c07903669c00abccf0dfdd05854de2
Author: Nicolas Schier <n.schier@fritz.com>

Move struct cpu_feature to a <linux/device-id/cpu_feature.h>

This commit moves the definition of struct cpu_feature from
<linux/mod_devicetable.h> into a new <linux/device-id/cpu_feature.h> header
and updates <linux/cpufeature.h> and arch/loongarch/kvm/main.c to include
the new header directly.

Link: https://lore.kernel.org/r/f610c07f39df15f3e7ebdc63bfcd759ca7a687a8.1794233316.git.sashal@kernel.org # [1]

> diff --git a/include/linux/cpufeature.h b/include/linux/cpufeature.h
> index 6aff540ee9e57..cd470987777f3 100644
> --- a/include/linux/cpufeature.h
> +++ b/include/linux/cpufeature.h
> @@ -6,10 +6,11 @@
>  #ifndef __LINUX_CPUFEATURE_H
>  #define __LINUX_CPUFEATURE_H
>  
> +#include <linux/device-id/cpu_feature.h>
> +
>  #ifdef CONFIG_GENERIC_CPU_AUTOPROBE
>  
>  #include <linux/init.h>
> -#include <linux/mod_devicetable.h>
>  #include <asm/cpufeature.h>
>  
>  /*

[Severity: High]
Does removing <linux/mod_devicetable.h> here break the s390 build when
CONFIG_PKEY_CCA=m or CONFIG_PKEY_EP11=m?

drivers/s390/crypto/pkey_cca.c and drivers/s390/crypto/pkey_ep11.c define
arrays of struct ap_device_id (pkey_cca_card_ids[] and
pkey_ep11_card_ids[]) without directly including <linux/device-id/ap.h>.
They previously got that definition transitively through
<linux/cpufeature.h> -> <linux/mod_devicetable.h>, so struct ap_device_id
is now an incomplete type in both files.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120202712.3377691-1-nsc@kernel.org?part=1

  parent reply	other threads:[~2026-11-21 20:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1792144769.git.u.kleine-koenig@baylibre.com>
     [not found] ` <179416565740.60865.16102443399828949110.b4-review@b4>
2026-11-09 14:14   ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Sasha Levin
2026-11-09 14:14     ` [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header Sasha Levin
2026-11-09 15:57       ` Uwe Kleine-König
2026-11-09 16:07       ` Nicolas Schier
2026-11-19 15:24         ` Nicolas Schier
2026-11-19 19:47           ` Nathan Chancellor
2026-11-20 11:25             ` Uwe Kleine-König
2026-11-20 20:21               ` Nicolas Schier
2026-11-20 20:27                 ` [PATCH] Move struct cpu_feature to a <linux/device-id/cpu_feature.h> Nicolas Schier
2026-11-21 12:01                   ` kernel test robot
2026-11-21 12:51                     ` Nicolas Schier
2026-11-21 20:27                   ` sashiko-bot [this message]
2026-11-09 15:48     ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Uwe Kleine-König
2026-11-13 13:38       ` Harald Freudenberger
2026-11-09 16:07     ` Nicolas Schier
2026-11-13 13:30     ` Harald Freudenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227340@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=bot@kernelci.org \
    --cc=chenhuacai@kernel.org \
    --cc=dengler@linux.ibm.com \
    --cc=freude@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kernel@xen0n.name \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=n.schier@fritz.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=sashal@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tsbogend@alpha.franken.de \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox