From: Vasily Gorbik <gor@linux.ibm.com>
To: Harald Freudenberger <freude@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v5 0/1] Rework pkey ioctl functions error paths
Date: Thu, 23 Jul 2026 12:09:34 +0200 [thread overview]
Message-ID: <ttimhjy@ub.hpns> (raw)
In-Reply-To: <20260722142947.109588-1-freude@linux.ibm.com>
On Wed, Jul 22, 2026 at 04:29:46PM +0200, Harald Freudenberger wrote:
> Slight rework for all the pkey ioctl functions, especially related to
> the error paths with regard to free memory. This patch removes all
> this duplicated code and introduces one code block at the end of the
> functions which is jumped into via goto out or executed on regular
> exit.
>
> Changelog:
> v1 - first version
> v2 - just a rebase of the v1 patch as the original patch did not apply
> any more.
> v3 - Fix paths where a error ptr returned from a helper function may
> be used as input for kfree(). Fixed typo pathes -> paths
> v4 - Added yet another slight rework covering the possible use of an
> uninitialized variable in an error path.
> v5 - Resend without any code changes, just Finn's reviewed by added.
>
> Harald Freudenberger (1):
> s390/pkey: Rework ioctl functions error paths
>
> drivers/s390/crypto/pkey_api.c | 288 ++++++++++++++++++---------------
> 1 file changed, 157 insertions(+), 131 deletions(-)
Applied, thank you!
prev parent reply other threads:[~2026-07-23 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 14:29 [PATCH v5 0/1] Rework pkey ioctl functions error paths Harald Freudenberger
2026-07-22 14:29 ` [PATCH v5 1/1] s390/pkey: Rework " Harald Freudenberger
2026-07-22 14:37 ` sashiko-bot
2026-07-23 10:09 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ttimhjy@ub.hpns \
--to=gor@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox