From: Vasily Gorbik <gor@linux.ibm.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] s390/mm: Explicitly compare PAGE_DEFAULT_KEY against zero in storage_key_init_range
Date: Mon, 17 Feb 2020 18:07:33 +0100 [thread overview]
Message-ID: <your-ad-here.call-01581959253-ext-9953@work.hours> (raw)
In-Reply-To: <20200214064207.10381-1-natechancellor@gmail.com>
On Thu, Feb 13, 2020 at 11:42:07PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from ../arch/s390/purgatory/purgatory.c:10:
> In file included from ../include/linux/kexec.h:18:
> In file included from ../include/linux/crash_core.h:6:
> In file included from ../include/linux/elfcore.h:5:
> In file included from ../include/linux/user.h:1:
> In file included from ../arch/s390/include/asm/user.h:11:
> ../arch/s390/include/asm/page.h:45:6: warning: converting the result of
> '<<' to a boolean always evaluates to false
> [-Wtautological-constant-compare]
> if (PAGE_DEFAULT_KEY)
> ^
> ../arch/s390/include/asm/page.h:23:44: note: expanded from macro
> 'PAGE_DEFAULT_KEY'
> #define PAGE_DEFAULT_KEY (PAGE_DEFAULT_ACC << 4)
> ^
> 1 warning generated.
>
> Explicitly compare this against zero to silence the warning as it is
> intended to be used in a boolean context.
>
> Fixes: de3fa841e429 ("s390/mm: fix compile for PAGE_DEFAULT_KEY != 0")
> Link: https://github.com/ClangBuiltLinux/linux/issues/860
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
Applied to fixes, thanks
prev parent reply other threads:[~2020-02-17 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:42 [PATCH] s390/mm: Explicitly compare PAGE_DEFAULT_KEY against zero in storage_key_init_range Nathan Chancellor
2020-02-14 7:34 ` Christian Borntraeger
2020-02-17 17:07 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01581959253-ext-9953@work.hours \
--to=gor@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox