public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasily Gorbik <gor@linux.ibm.com>
To: qiwuchen55@gmail.com
Cc: sebott@linux.ibm.com, oberpar@linux.ibm.com,
	heiko.carstens@de.ibm.com, borntraeger@de.ibm.com,
	linux-s390@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH v2] s390/cio: use kobj_to_dev() API
Date: Mon, 17 Feb 2020 18:08:04 +0100	[thread overview]
Message-ID: <your-ad-here.call-01581959284-ext-3641@work.hours> (raw)
In-Reply-To: <1581688293-17283-1-git-send-email-qiwuchen55@gmail.com>

On Fri, Feb 14, 2020 at 09:51:33PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> Use kobj_to_dev() API instead of container_of().
> 
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
> Signed-off-by: chenqiwu <qiwuchen55@gmail.com>
> ---
> changes in v2:
>  - add signed off for my gmail adderss.
> --- 
>  drivers/s390/cio/chp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/cio/chp.c b/drivers/s390/cio/chp.c
> index 51038ec..dfcbe54 100644
> --- a/drivers/s390/cio/chp.c
> +++ b/drivers/s390/cio/chp.c
> @@ -135,7 +135,7 @@ static ssize_t chp_measurement_chars_read(struct file *filp,
>  	struct channel_path *chp;
>  	struct device *device;
>  
> -	device = container_of(kobj, struct device, kobj);
> +	device = kobj_to_dev(kobj);
>  	chp = to_channelpath(device);
>  	if (chp->cmg == -1)
>  		return 0;
> @@ -184,7 +184,7 @@ static ssize_t chp_measurement_read(struct file *filp, struct kobject *kobj,
>  	struct device *device;
>  	unsigned int size;
>  
> -	device = container_of(kobj, struct device, kobj);
> +	device = kobj_to_dev(kobj);
>  	chp = to_channelpath(device);
>  	css = to_css(chp->dev.parent);
>  
> -- 
> 1.9.1
> 
Applied, thanks

      parent reply	other threads:[~2020-02-17 17:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 13:51 [PATCH v2] s390/cio: use kobj_to_dev() API qiwuchen55
2020-02-14 15:32 ` Cornelia Huck
2020-02-17 17:08 ` Vasily Gorbik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=your-ad-here.call-01581959284-ext-3641@work.hours \
    --to=gor@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chenqiwu@xiaomi.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    --cc=qiwuchen55@gmail.com \
    --cc=sebott@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox