From: Vasily Gorbik <gor@linux.ibm.com>
To: Yejune Deng <yejune.deng@gmail.com>
Cc: hca@linux.ibm.com, borntraeger@de.ibm.com, tglx@linutronix.de,
keescook@chromium.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, Yejune Deng <yejunedeng@gmail.com>
Subject: Re: [PATCH] softirq/s390: Use the generic local_softirq_pending()
Date: Thu, 27 May 2021 02:06:23 +0200 [thread overview]
Message-ID: <your-ad-here.call-01622073983-ext-1568@work.hours> (raw)
In-Reply-To: <1621859957-4880-1-git-send-email-yejunedeng@gmail.com>
On Mon, May 24, 2021 at 08:39:17PM +0800, Yejune Deng wrote:
> Defined local_softirq_pending_ref macro and get rid of {local, set, or}
> _softirq_pending macros. use {local, set, or}_softirq_pending
> in <linux/interrupt.h> that rely on per-CPU mutators.
>
> Signed-off-by: Yejune Deng <yejunedeng@gmail.com>
> ---
> arch/s390/include/asm/hardirq.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/s390/include/asm/hardirq.h b/arch/s390/include/asm/hardirq.h
> index 58668ff..ea643d6 100644
> --- a/arch/s390/include/asm/hardirq.h
> +++ b/arch/s390/include/asm/hardirq.h
> @@ -13,9 +13,7 @@
>
> #include <asm/lowcore.h>
>
> -#define local_softirq_pending() (S390_lowcore.softirq_pending)
> -#define set_softirq_pending(x) (S390_lowcore.softirq_pending = (x))
> -#define or_softirq_pending(x) (S390_lowcore.softirq_pending |= (x))
> +#define local_softirq_pending_ref S390_lowcore.softirq_pending
S390_lowcore is not a per-CPU variable, so it cannot be accessed with
__this_cpu_read/write...
"lowcore" is a kind of hardware "per-CPU" area on s390. Each cpu accessing
first 2 pages at the real address 0 is actually touching pages at the
"absolute" address specified by prefix register of this cpu.
next prev parent reply other threads:[~2021-05-27 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 12:39 [PATCH] softirq/s390: Use the generic local_softirq_pending() Yejune Deng
2021-05-27 0:06 ` Vasily Gorbik [this message]
2021-05-27 23:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01622073983-ext-1568@work.hours \
--to=gor@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yejune.deng@gmail.com \
--cc=yejunedeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox