From: Vasily Gorbik <gor@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] S390: appldata depends on PROC_SYSCTL
Date: Mon, 31 May 2021 16:09:20 +0200 [thread overview]
Message-ID: <your-ad-here.call-01622470160-ext-4376@work.hours> (raw)
In-Reply-To: <20210528002420.17634-1-rdunlap@infradead.org>
On Thu, May 27, 2021 at 05:24:20PM -0700, Randy Dunlap wrote:
> APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
> Building with PROC_FS but not PROC_SYSCTL causes a build error,
> since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.
>
> arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
> appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'
>
> Fixes: c185b783b099 ("[S390] Remove config options.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
> arch/s390/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210526.orig/arch/s390/Kconfig
> +++ linux-next-20210526/arch/s390/Kconfig
> @@ -853,7 +853,7 @@ config CMM_IUCV
> config APPLDATA_BASE
> def_bool n
> prompt "Linux - VM Monitor Stream, base infrastructure"
> - depends on PROC_FS
> + depends on PROC_SYSCTL
> help
> This provides a kernel interface for creating and updating z/VM APPLDATA
> monitor records. The monitor records are updated at certain time
Applied, thanks
prev parent reply other threads:[~2021-05-31 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 0:24 [PATCH] S390: appldata depends on PROC_SYSCTL Randy Dunlap
2021-05-31 14:09 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01622470160-ext-4376@work.hours \
--to=gor@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox