From: Vasily Gorbik <gor@linux.ibm.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
kernel test robot <lkp@intel.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/purgatory: Use -D__DISABLE_EXPORTS
Date: Mon, 17 Feb 2025 19:25:18 +0100 [thread overview]
Message-ID: <your-ad-here.call-01739816718-ext-0992@work.hours> (raw)
In-Reply-To: <20250213211614.3537605-2-samitolvanen@google.com>
On Thu, Feb 13, 2025 at 09:16:14PM +0000, Sami Tolvanen wrote:
> The object files in purgatory do not export symbols, so disable exports
> for all the object files, not only sha256.o, with -D__DISABLE_EXPORTS.
>
> This fixes a build failure with CONFIG_GENDWARFKSYMS, where we would
> otherwise attempt to calculate symbol versions for purgatory objects and
> fail because they're not built with debugging information:
>
> error: gendwarfksyms: process_module: dwarf_get_units failed: no debugging information?
> make[5]: *** [../scripts/Makefile.build:207: arch/s390/purgatory/string.o] Error 1
> make[5]: *** Deleting file 'arch/s390/purgatory/string.o'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502120752.U3fOKScQ-lkp@intel.com/
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> ---
> arch/s390/purgatory/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thank you!
prev parent reply other threads:[~2025-02-17 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 21:16 [PATCH] s390/purgatory: Use -D__DISABLE_EXPORTS Sami Tolvanen
2025-02-17 18:25 ` Vasily Gorbik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-ad-here.call-01739816718-ext-0992@work.hours \
--to=gor@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=samitolvanen@google.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox