From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Tomasz Figa' <t.figa@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, patches@linaro.org
Subject: RE: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
Date: Thu, 17 Jan 2013 15:59:47 -0800 [thread overview]
Message-ID: <001a01cdf50e$bbead8d0$33c08a70$@samsung.com> (raw)
In-Reply-To: <5436877.rqOLY7SjmE@amdc1227>
Tomasz Figa wrote:
>
> Hi Sachin,
>
> On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
> > Added vmmc regulator node in exynos4412-origen.dts file.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > arch/arm/boot/dts/exynos4412-origen.dts | 9 +++++++++
> > 1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> > b/arch/arm/boot/dts/exynos4412-origen.dts index df880c4..fe70bc6
> 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -27,6 +27,15 @@
> > bootargs ="console=ttySAC2,115200";
> > };
> >
> > + mmc_reg: voltage-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "VMEM_VDD_2.8V";
> > + regulator-min-microvolt = <2800000>;
> > + regulator-max-microvolt = <2800000>;
> > + gpio = <&gpx1 1 0>;
> > + enable-active-high;
> > + };
> > +
> > serial@13800000 {
> > status = "okay";
> > };
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Looks good to me, applied 1/2 and 2/2.
Thanks for review and posting.
- Kukjin
prev parent reply other threads:[~2013-01-18 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 5:48 [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Sachin Kamat
2013-01-17 5:48 ` [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen Sachin Kamat
2013-01-17 9:27 ` Tomasz Figa
2013-01-17 9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
2013-01-17 9:49 ` Sachin Kamat
2013-01-17 23:59 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01cdf50e$bbead8d0$33c08a70$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox