Linux Samsung SOC development
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
@ 2013-01-17  5:48 Sachin Kamat
  2013-01-17  5:48 ` [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen Sachin Kamat
  2013-01-17  9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
  0 siblings, 2 replies; 6+ messages in thread
From: Sachin Kamat @ 2013-01-17  5:48 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: kgene.kim, sachin.kamat, patches

Added vmmc regulator node in exynos4412-origen.dts file.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4412-origen.dts |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index df880c4..fe70bc6 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -27,6 +27,15 @@
 		bootargs ="console=ttySAC2,115200";
 	};
 
+	mmc_reg: voltage-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "VMEM_VDD_2.8V";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		gpio = <&gpx1 1 0>;
+		enable-active-high;
+	};
+
 	serial@13800000 {
 		status = "okay";
 	};
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen
  2013-01-17  5:48 [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Sachin Kamat
@ 2013-01-17  5:48 ` Sachin Kamat
  2013-01-17  9:27   ` Tomasz Figa
  2013-01-17  9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
  1 sibling, 1 reply; 6+ messages in thread
From: Sachin Kamat @ 2013-01-17  5:48 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: kgene.kim, sachin.kamat, patches

Added sdhci node for exynos4412-origen.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4412-origen.dts |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index fe70bc6..4eba374 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -36,6 +36,14 @@
 		enable-active-high;
 	};
 
+	sdhci@12530000 {
+		bus-width = <4>;
+		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
+		pinctrl-names = "default";
+		vmmc-supply = <&mmc_reg>;
+		status = "okay";
+	};
+
 	serial@13800000 {
 		status = "okay";
 	};
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
  2013-01-17  5:48 [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Sachin Kamat
  2013-01-17  5:48 ` [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen Sachin Kamat
@ 2013-01-17  9:26 ` Tomasz Figa
  2013-01-17  9:49   ` Sachin Kamat
  2013-01-17 23:59   ` Kukjin Kim
  1 sibling, 2 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-01-17  9:26 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-samsung-soc, kgene.kim, patches

Hi Sachin,

On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
> Added vmmc regulator node in exynos4412-origen.dts file.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4412-origen.dts |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts index df880c4..fe70bc6 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -27,6 +27,15 @@
>  		bootargs ="console=ttySAC2,115200";
>  	};
> 
> +	mmc_reg: voltage-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VMEM_VDD_2.8V";
> +		regulator-min-microvolt = <2800000>;
> +		regulator-max-microvolt = <2800000>;
> +		gpio = <&gpx1 1 0>;
> +		enable-active-high;
> +	};
> +
>  	serial@13800000 {
>  		status = "okay";
>  	};

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen
  2013-01-17  5:48 ` [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen Sachin Kamat
@ 2013-01-17  9:27   ` Tomasz Figa
  0 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-01-17  9:27 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-samsung-soc, kgene.kim, patches

Hi Sachin,

On Thursday 17 of January 2013 11:18:13 Sachin Kamat wrote:
> Added sdhci node for exynos4412-origen.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4412-origen.dts |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts index fe70bc6..4eba374 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -36,6 +36,14 @@
>  		enable-active-high;
>  	};
> 
> +	sdhci@12530000 {
> +		bus-width = <4>;
> +		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
> +		pinctrl-names = "default";
> +		vmmc-supply = <&mmc_reg>;
> +		status = "okay";
> +	};
> +
>  	serial@13800000 {
>  		status = "okay";
>  	};


Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
  2013-01-17  9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
@ 2013-01-17  9:49   ` Sachin Kamat
  2013-01-17 23:59   ` Kukjin Kim
  1 sibling, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2013-01-17  9:49 UTC (permalink / raw)
  To: Tomasz Figa; +Cc: linux-samsung-soc

Hi Tomasz

On 17 January 2013 14:56, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Sachin,
>
> On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
>> Added vmmc regulator node in exynos4412-origen.dts file.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>

Thank you for reviewing the patches.


-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
  2013-01-17  9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
  2013-01-17  9:49   ` Sachin Kamat
@ 2013-01-17 23:59   ` Kukjin Kim
  1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-01-17 23:59 UTC (permalink / raw)
  To: 'Tomasz Figa', 'Sachin Kamat'; +Cc: linux-samsung-soc, patches

Tomasz Figa wrote:
> 
> Hi Sachin,
> 
> On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
> > Added vmmc regulator node in exynos4412-origen.dts file.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  arch/arm/boot/dts/exynos4412-origen.dts |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> > b/arch/arm/boot/dts/exynos4412-origen.dts index df880c4..fe70bc6
> 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -27,6 +27,15 @@
> >  		bootargs ="console=ttySAC2,115200";
> >  	};
> >
> > +	mmc_reg: voltage-regulator {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "VMEM_VDD_2.8V";
> > +		regulator-min-microvolt = <2800000>;
> > +		regulator-max-microvolt = <2800000>;
> > +		gpio = <&gpx1 1 0>;
> > +		enable-active-high;
> > +	};
> > +
> >  	serial@13800000 {
> >  		status = "okay";
> >  	};
> 
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> 
Looks good to me, applied 1/2 and 2/2.

Thanks for review and posting.

- Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-01-18  0:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-17  5:48 [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Sachin Kamat
2013-01-17  5:48 ` [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen Sachin Kamat
2013-01-17  9:27   ` Tomasz Figa
2013-01-17  9:26 ` [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts Tomasz Figa
2013-01-17  9:49   ` Sachin Kamat
2013-01-17 23:59   ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox