From: Jingoo Han <jg1.han@samsung.com>
To: 'Joe Perches' <joe@perches.com>
Cc: 'Mark Brown' <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH V2 2/2] spi: s3c64xx: fix checkpatch error and warnings
Date: Tue, 16 Jul 2013 08:23:41 +0900 [thread overview]
Message-ID: <002e01ce81b2$5825d800$08718800$@samsung.com> (raw)
In-Reply-To: <1373890206.2062.4.camel@joe-AO722>
On Monday, July 15, 2013 9:10 PM, Joe Perches wrote:
> On Mon, 2013-07-15 at 15:11 +0900, Jingoo Han wrote:
> []
> > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> []
> > @@ -338,8 +338,10 @@ static int acquire_dma(struct s3c64xx_spi_driver_data *sdd)
> []
> > - sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach, &req, dev, "rx");
> > - sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach, &req, dev, "tx");
> > + sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach,
> > + &req, dev, "rx");
> > + sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach,
> > + &req, dev, "tx");
>
> There should be sparse errors here.
> sdd->ops->request is unsigned int, not unsigned long.
> Care to fix the cast of unsigned to pointer too?
OK, I will fix it as below:
sdd->rx_dma.ch = (unsigned long *)sdd->ops->request(sdd->rx_dma.dmach,
&req, dev, "rx");
sdd->tx_dma.ch = (unsigned long *)sdd->ops->request(sdd->tx_dma.dmach,
&req, dev, "tx");
>
> > @@ -439,7 +441,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi)
> >
> > /* Acquire DMA channels */
> > sdd->rx_dma.ch = dma_request_slave_channel_compat(mask, filter,
> > - (void*)sdd->rx_dma.dmach, dev, "rx");
> > + (void *)sdd->rx_dma.dmach, dev, "rx");
>
> It seems unsigned to pointer conversions are pretty
> rampant in this code.
It seems so.
I will look into it, later.
Thank you for your feedback.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-07-15 23:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 6:11 [PATCH V2 2/2] spi: s3c64xx: fix checkpatch error and warnings Jingoo Han
2013-07-15 12:00 ` Mark Brown
2013-07-15 12:10 ` Joe Perches
2013-07-15 23:23 ` Jingoo Han [this message]
2013-07-15 23:37 ` Joe Perches
2013-07-15 23:40 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002e01ce81b2$5825d800$08718800$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox