* [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver
@ 2013-10-21 1:52 Jingoo Han
2013-10-21 1:53 ` [PATCH 2/2] ARM: EXYNOS: Remove incorrect __init annotation from " Jingoo Han
2013-10-30 22:12 ` [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for " Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-10-21 1:52 UTC (permalink / raw)
To: 'Rafael J. Wysocki', linux-pm
Cc: 'Kukjin Kim', 'Daniel Lezcano',
'Tomasz Figa', 'Amit Daniel Kachhap',
'Bartlomiej Zolnierkiewicz', linux-samsung-soc,
linux-arm-kernel, 'Jingoo Han'
Change raw printk() call to dev_err() to provide a better message
to userspace so it can properly identify the device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
- Based against pm-cpuidle branch
- Tested on Exynos5440
arch/arm/mach-exynos/cpuidle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index 1bde6ad..6616e0f 100644
--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -206,7 +206,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev)
ret = cpuidle_register_driver(&exynos4_idle_driver);
if (ret) {
- printk(KERN_ERR "CPUidle failed to register driver\n");
+ dev_err(&pdev->dev, "failed to register cpuidle driver\n");
return ret;
}
@@ -220,7 +220,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev)
ret = cpuidle_register_device(device);
if (ret) {
- printk(KERN_ERR "CPUidle register device failed\n");
+ dev_err(&pdev->dev, "failed to register cpuidle device\n");
return ret;
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: EXYNOS: Remove incorrect __init annotation from cpuidle driver
2013-10-21 1:52 [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver Jingoo Han
@ 2013-10-21 1:53 ` Jingoo Han
2013-10-30 22:12 ` [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for " Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-10-21 1:53 UTC (permalink / raw)
To: 'Rafael J. Wysocki', linux-pm
Cc: 'Kukjin Kim', 'Daniel Lezcano',
'Tomasz Figa', 'Amit Daniel Kachhap',
'Bartlomiej Zolnierkiewicz', linux-samsung-soc,
linux-arm-kernel, 'Jingoo Han'
When platform_driver_probe() is not used, bind/unbind via sysfs is
enabled. Thus, __init annotation should be removed from probe().
Also, this patch fixes section mismatch warning.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
- Based against pm-cpuidle branch
- Tested on Exynos5440
arch/arm/mach-exynos/cpuidle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index 6616e0f..ddbfe87 100644
--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -193,7 +193,7 @@ static void __init exynos5_core_down_clk(void)
__raw_writel(tmp, EXYNOS5_PWR_CTRL2);
}
-static int __init exynos_cpuidle_probe(struct platform_device *pdev)
+static int exynos_cpuidle_probe(struct platform_device *pdev)
{
int cpu_id, ret;
struct cpuidle_device *device;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver
2013-10-21 1:52 [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver Jingoo Han
2013-10-21 1:53 ` [PATCH 2/2] ARM: EXYNOS: Remove incorrect __init annotation from " Jingoo Han
@ 2013-10-30 22:12 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2013-10-30 22:12 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-pm, 'Kukjin Kim', 'Daniel Lezcano',
'Tomasz Figa', 'Amit Daniel Kachhap',
'Bartlomiej Zolnierkiewicz', linux-samsung-soc,
linux-arm-kernel
On Monday, October 21, 2013 10:52:15 AM Jingoo Han wrote:
> Change raw printk() call to dev_err() to provide a better message
> to userspace so it can properly identify the device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Both [1-2/2] queued up for 3.13, thanks!
> ---
> - Based against pm-cpuidle branch
> - Tested on Exynos5440
>
> arch/arm/mach-exynos/cpuidle.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 1bde6ad..6616e0f 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -206,7 +206,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev)
>
> ret = cpuidle_register_driver(&exynos4_idle_driver);
> if (ret) {
> - printk(KERN_ERR "CPUidle failed to register driver\n");
> + dev_err(&pdev->dev, "failed to register cpuidle driver\n");
> return ret;
> }
>
> @@ -220,7 +220,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev)
>
> ret = cpuidle_register_device(device);
> if (ret) {
> - printk(KERN_ERR "CPUidle register device failed\n");
> + dev_err(&pdev->dev, "failed to register cpuidle device\n");
> return ret;
> }
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-30 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 1:52 [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver Jingoo Han
2013-10-21 1:53 ` [PATCH 2/2] ARM: EXYNOS: Remove incorrect __init annotation from " Jingoo Han
2013-10-30 22:12 ` [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for " Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox