From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Kyungmin Park' <kmpark@infradead.org>,
linux-arm-kernel@lists.infradead.org
Cc: ben-linux@fluff.org, linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
Date: Thu, 07 Oct 2010 10:29:44 +0900 [thread overview]
Message-ID: <004301cb65bf$225c62f0$671528d0$%kim@samsung.com> (raw)
In-Reply-To: <20100930044832.GA16905@july>
Kyungmin Park wrote:
>
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Use the correct I2C2 interrupt.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/dev-i2c2.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-i2c2.c
b/arch/arm/plat-samsung/dev-i2c2.c
> index 07036de..ff4ba69 100644
> --- a/arch/arm/plat-samsung/dev-i2c2.c
> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
> .flags = IORESOURCE_MEM,
> },
> [1] = {
> - .start = IRQ_CAN0,
> - .end = IRQ_CAN0,
> + .start = IRQ_IIC2,
> + .end = IRQ_IIC2,
> .flags = IORESOURCE_IRQ,
> },
> };
> --
Hi,
Looks ok...
In my opinion, could you please merge your 2nd and this patch to one,
changing I2C2 interrupt name?
And need to add s5pc100's I2C2 interrupt name changing in there.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
parent reply other threads:[~2010-10-07 1:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20100930044832.GA16905@july>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004301cb65bf$225c62f0$671528d0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox