Linux Samsung SOC development
 help / color / mirror / Atom feed
* RE: [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
       [not found] <20100930044832.GA16905@july>
@ 2010-10-07  1:29 ` Kukjin Kim
  0 siblings, 0 replies; only message in thread
From: Kukjin Kim @ 2010-10-07  1:29 UTC (permalink / raw)
  To: 'Kyungmin Park', linux-arm-kernel; +Cc: ben-linux, linux-samsung-soc

Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Use the correct I2C2 interrupt.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/plat-samsung/dev-i2c2.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/dev-i2c2.c
b/arch/arm/plat-samsung/dev-i2c2.c
> index 07036de..ff4ba69 100644
> --- a/arch/arm/plat-samsung/dev-i2c2.c
> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
>  		.flags = IORESOURCE_MEM,
>  	},
>  	[1] = {
> -		.start = IRQ_CAN0,
> -		.end   = IRQ_CAN0,
> +		.start = IRQ_IIC2,
> +		.end   = IRQ_IIC2,
>  		.flags = IORESOURCE_IRQ,
>  	},
>  };
> --

Hi,

Looks ok...
In my opinion, could you please merge your 2nd and this patch to one,
changing I2C2 interrupt name?
And need to add s5pc100's I2C2 interrupt name changing in there.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-10-07  1:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100930044832.GA16905@july>
2010-10-07  1:29 ` [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox