RE: [PATCH] tty: serial: samsung_tty: loopback mode support

["Chanho Park" <chanho61.park@samsung.com>]

> Subject: Re: [PATCH] tty: serial: samsung_tty: loopback mode support
> 
> On Mon, Jun 27, 2022 at 12:23:53PM +0900, Chanho Park wrote:
> > Internal loopback mode can be supported by setting
> > S3C2443_UCON_LOOPBACK bit. The mode & bit can be supported since
> > s3c2410 and later SoCs. We can test it by linux-serial-test program[1]
> > with -k option. It will set TIOCM_LOOP mode during test.
> >
> > -k, --loopback     Use internal hardware loop back
> 
> I do not understand this line in the changelog text, what is it for?

Ah. I'd like to show the option of linux-serial-test tool how we can test
it.

> 
> >
> > [1]:
> > https://protect2.fireeye.com/v1/url?k=a0d4e46c-c15ff149-a0d56f23-74fe4
> > 85cbff6-c2c20e5c0d4f5c92&q=1&e=7c91006c-af87-4dad-8069-360450d31b36&u=
> > https%3A%2F%2Fgithub.com%2Fcbrake%2Flinux-serial-test
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> 
> Our tools require a blank line before the signed-off-by line.  Did you not
> get a warning when checking this patch before sending it out?

I'm able to see below warning. I'll fix it. Thanks.

WARNING: Do not use whitespace before Signed-off-by:

#15:

> 
> Also, no need for a footnote in a changelog that is so short, just put the
> link in the body of the text itself.

Okay. I'll put the link in the body instead of the footnote.

Best Regards,
Chanho Park