From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Ilpo Järvinen'" <ilpo.jarvinen@linux.intel.com>
Cc: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Jiri Slaby'" <jirislaby@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Hector Martin'" <marcan@marcan.st>,
"'Jaewon Kim'" <jaewon02.kim@samsung.com>,
"'Vincent Whitchurch'" <vincent.whitchurch@axis.com>,
<linux-samsung-soc@vger.kernel.org>,
"'linux-serial'" <linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] tty: serial: samsung_tty: loopback mode support
Date: Tue, 28 Jun 2022 20:55:13 +0900 [thread overview]
Message-ID: <018601d88ae5$ed2af930$c780eb90$@samsung.com> (raw)
In-Reply-To: <ab327a8f-f520-ad85-c0fc-1e505647164c@linux.intel.com>
> Subject: Re: [PATCH] tty: serial: samsung_tty: loopback mode support
>
> On Mon, 27 Jun 2022, Chanho Park wrote:
>
> > Internal loopback mode can be supported by setting
> > S3C2443_UCON_LOOPBACK bit. The mode & bit can be supported since
> > s3c2410 and later SoCs.
>
> In that case, why is the LOOPBACK define named 2443 and not 2410???
It might be copied from mach-s3c24xx.
>
> The change looks fine otherwise.
>
> I note though that many of the current drivers won't return TOICM_LOOP
> from ->get_mctrl() but I don't think it's exactly wrong to return it
> either. Perhaps lack of returning it is due to Documentation/driver-
> api/serial/driver.rst not including TOICM_LOOP in get_mctrl's list of
> information but only in set_mctrl's one.
According to the description, TIOCM_LOOP bit might be used only for setting.
I'll drop the bit manipulation from get_mctrl callback.
Thanks for the heads up.
Best Regards,
Chanho Park
next prev parent reply other threads:[~2022-06-28 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220627032556epcas2p26c2cd2786888a5018607bf651bc5dec0@epcas2p2.samsung.com>
2022-06-27 3:23 ` [PATCH] tty: serial: samsung_tty: loopback mode support Chanho Park
2022-06-27 11:28 ` Krzysztof Kozlowski
2022-06-27 11:46 ` Ilpo Järvinen
2022-06-28 11:55 ` Chanho Park [this message]
2022-06-27 12:39 ` Greg Kroah-Hartman
2022-06-28 4:49 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='018601d88ae5$ed2af930$c780eb90$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jaewon02.kim@samsung.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox