RE: [PATCH 08/13] ARM: S5P64X0: Move DMA support for S5P64X0

[Kukjin Kim <kgene.kim@samsung.com>]

Jassi Brar wrote:
> 
> On Wed, Sep 1, 2010 at 4:09 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > This patch moves DMA support files in the mach-s5p64x0
> > for S5P6440 and S5P6450 SoCs.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: Jassi Brar <jassi.brar@samsung.com>
> > ---
> >  arch/arm/{mach-s5p6440 => mach-s5p64x0}/dma.c      |   75
> ++++++++++++++++---
> >  .../include/mach/dma.h                             |    0
> >  arch/arm/plat-samsung/include/plat/s3c-dma-pl330.h |   28 +++++++
> >  3 files changed, 91 insertions(+), 12 deletions(-)
> >  rename arch/arm/{mach-s5p6440 => mach-s5p64x0}/dma.c (56%)
> >  rename arch/arm/{mach-s5p6440 => mach-s5p64x0}/include/mach/dma.h (100%)
> >

(snip)

> > +
> >  static struct platform_device s5p6440_device_pdma = {
> >        .name           = "s3c-pl330",
> >        .id             = 1,
> 
> While at it, please make id 0  as well.
> 
Ok..will fix it.

> 
> > -       .num_resources  = ARRAY_SIZE(s5p6440_pdma_resource),
> > -       .resource       = s5p6440_pdma_resource,
> > +       .num_resources  = ARRAY_SIZE(s5p64x0_pdma_resource),
> > +       .resource       = s5p64x0_pdma_resource,
> >        .dev            = {
> >                .dma_mask = &dma_dmamask,
> >                .coherent_dma_mask = DMA_BIT_MASK(32),
> > @@ -92,14 +130,27 @@ static struct platform_device s5p6440_device_pdma = {
> >        },
> >  };
> >
> > -static struct platform_device *s5p6440_dmacs[] __initdata = {
> > +static struct platform_device s5p6450_device_pdma = {
> > +       .name           = "s3c-pl330",
> > +       .id             = 0,
> > +       .num_resources  = ARRAY_SIZE(s5p64x0_pdma_resource),
> > +       .resource       = s5p64x0_pdma_resource,
> > +       .dev            = {
> > +               .dma_mask = &dma_dmamask,
> > +               .coherent_dma_mask = DMA_BIT_MASK(32),
> > +               .platform_data = &s5p6450_pdma_pdata,
> > +       },
> > +};
> > +
> > +static struct platform_device *s5p64x0_dmacs[] __initdata = {
> >        &s5p6440_device_pdma,
> > +       /* &s5p6450_device_pdma will be added */
> >  };
> Let us simply call the DMAC as s5p64x0_device_pdma and use some
> CPU detection method in s5p64x0_dma_init to assign either of
> s5p6440_pdma_pdata and s5p6450_pdma_pdata to the platform_data
> 
Ok.

> ........
> 
> > +       DMACH_MTOM_0,
> > +       DMACH_MTOM_1,
> > +       DMACH_MTOM_2,
> > +       DMACH_MTOM_3,
> > +       DMACH_MTOM_4,
> > +       DMACH_MTOM_5,
> > +       DMACH_MTOM_6,
> > +       DMACH_MTOM_7,
> 
> oops ... Mainline s3c dma api doesn't yet support Mem->Mem transfers.
> You need to drop it.

Oh, you're right. it's my mistake.
Will fix it. :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.