From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Kyungmin Park' <kmpark@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org
Subject: RE: [PATCH 02/13] ARM: S5P64X0: Update Kconfig and Makefile
Date: Thu, 02 Sep 2010 17:25:38 +0900 [thread overview]
Message-ID: <004b01cb4a78$74552860$5cff7920$%kim@samsung.com> (raw)
In-Reply-To: <AANLkTin_aQvv_U9z7VxGM-3VWMj-iWdS928aB30sETWp@mail.gmail.com>
Kyungmin Park wrote:
>
> On Wed, Sep 1, 2010 at 4:09 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > This patch updates the Kconfig and Makefile for the S5P6440 and S5P6450
> > machines. It also updates arch/arm/ Kconfig and Makefile to include for
> > support ARCH_S5P64X0 with one kernel image.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > arch/arm/Kconfig | 16 +++---
> > arch/arm/Makefile | 2 +-
> > arch/arm/mach-s5p6440/Kconfig | 33 ------------
> > arch/arm/mach-s5p6440/Makefile | 25 ---------
> > arch/arm/mach-s5p64x0/Kconfig | 55
> ++++++++++++++++++++
> > arch/arm/mach-s5p64x0/Makefile | 30 +++++++++++
> > .../{mach-s5p6440 => mach-s5p64x0}/Makefile.boot | 0
> > arch/arm/plat-s5p/Kconfig | 4 +-
> > 8 files changed, 95 insertions(+), 70 deletions(-)
> > delete mode 100644 arch/arm/mach-s5p6440/Kconfig
> > delete mode 100644 arch/arm/mach-s5p6440/Makefile
> > create mode 100644 arch/arm/mach-s5p64x0/Kconfig
> > create mode 100644 arch/arm/mach-s5p64x0/Makefile
> > rename arch/arm/{mach-s5p6440 => mach-s5p64x0}/Makefile.boot (100%)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index a7ed21f..40e75b3 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -679,17 +679,15 @@ config ARCH_S3C64XX
> > help
> > Samsung S3C64XX series based systems
> >
> > -config ARCH_S5P6440
> > - bool "Samsung S5P6440"
> > +config ARCH_S5P64X0
> > + bool "Samsung S5P6440 S5P6450"
> > select CPU_V6
> > select GENERIC_GPIO
> > select HAVE_CLK
> > - select HAVE_S3C2410_WATCHDOG
> > select ARCH_USES_GETTIMEOFFSET
> > - select HAVE_S3C2410_I2C
> > - select HAVE_S3C_RTC
>
> Why HAVE_* is deleted?
>
Ok...will add it.
> > help
> > - Samsung S5P6440 CPU based systems
> > + Samsung S5P64X0 CPU based systems, such as the Samsung
> SMDK6440,
> > + SMDK6450.
> >
(snip)
> > +
> > +config MACH_SMDK6440
> > + bool "SMDK6440"
> > + select CPU_S5P6440
> > + select S3C_DEV_I2C1
> > + select S3C_DEV_RTC
> > + select S3C_DEV_WDT
> > + select SAMSUNG_DEV_ADC
> > + select SAMSUNG_DEV_TS
> > + select S5P64X0_SETUP_I2C1
> > + help
> > + Machine support for the Samsung SMDK6440
> > +
> > +config MACH_SMDK6450
> > + bool "SMDK6450"
> > + select CPU_S5P6450
> > + select S3C_DEV_I2C1
> > + select S3C_DEV_RTC
> > + select S3C_DEV_WDT
> > + select SAMSUNG_DEV_ADC
> > + select SAMSUNG_DEV_TS
> > + select S5P64X0_SETUP_I2C1
> > + help
> > + Machine support for the Samsung SMDK6450
>
> In most case SMDK has almost same functionality. make a common select
> e.g., SMDK_COMMON and each board just select it.
If required, will sort out next time with other architectures.
(snip)
> > +
> > +obj-$(CONFIG_MACH_SMDK6440) += mach-smdk6440.o
> > +obj-$(CONFIG_MACH_SMDK6450) += mach-smdk6450.o
> Are there difference between smdk6440 and smdk6450 except the SOC?
> If no, how about to make a single file as pxa or omap does?
>
Because each components on the board are different,
SMDK6440 and SMDK6450 need each machine file...
(snip)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-09-02 8:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 7:09 [PATCH 00/13] ARM: S5P64X0: Add new S5P6450 Support Kukjin Kim
2010-09-01 7:09 ` [PATCH 01/13] ARM: S5P: Moves initial map for merging S5P64X0 Kukjin Kim
2010-09-01 9:42 ` Kyungmin Park
2010-09-01 7:09 ` [PATCH 02/13] ARM: S5P64X0: Update Kconfig and Makefile Kukjin Kim
2010-09-01 9:47 ` Kyungmin Park
2010-09-02 8:25 ` Kukjin Kim [this message]
2010-09-01 7:09 ` [PATCH 03/13] ARM: S5P64X0: Add S5P64X0(S5P6440 and S5P6450) initialization support Kukjin Kim
2010-09-01 7:09 ` [PATCH 04/13] ARM: S5P64X0: Update Clock for S5P6440 and S5P6450 Kukjin Kim
2010-09-01 7:09 ` [PATCH 05/13] ARM: S5P64X0: Update IRQ support Kukjin Kim
2010-09-01 7:09 ` [PATCH 06/13] ARM: S5P64X0: Update Timer support Kukjin Kim
2010-09-01 7:09 ` [PATCH 07/13] ARM: S5P64X0: Update Audio support Kukjin Kim
2010-09-02 1:44 ` Jassi Brar
2010-09-02 7:30 ` Kukjin Kim
2010-09-01 7:09 ` [PATCH 08/13] ARM: S5P64X0: Move DMA support for S5P64X0 Kukjin Kim
2010-09-02 1:08 ` Jassi Brar
2010-09-02 7:32 ` Kukjin Kim
2010-09-01 7:09 ` [PATCH 09/13] ARM: S5P64X0: Add S5P6450 I2C support Kukjin Kim
2010-09-01 7:09 ` [PATCH 10/13] ARM: S5P64X0: Move GPIO support files for merge S5P64X0 Kukjin Kim
2010-09-01 7:09 ` [PATCH 11/13] ARM: S5P64X0: Move SMDK6440 board file and Add SMDK6450 board file Kukjin Kim
2010-09-01 10:00 ` Kyungmin Park
2010-09-02 8:02 ` Kukjin Kim
2010-09-01 7:09 ` [PATCH 12/13] ARM: S5P64X0: Add UART serial support for S5P6450 Kukjin Kim
2010-09-02 1:43 ` Kyungmin Park
2010-09-01 7:09 ` [PATCH 13/13] ARM: s5p64x0_defconfig: Update for support S5P6440 and S5P6450 Kukjin Kim
2010-09-01 11:45 ` [PATCH 00/13] ARM: S5P64X0: Add new S5P6450 Support Ben Dooks
2010-09-02 10:21 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004b01cb4a78$74552860$5cff7920$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox