Re: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o

Re: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o

[Krzysztof Kozlowski]

2015-08-13 20:33 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> On 13-08-15, 13:28, Jonas Rabenstein wrote:
>> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
>> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
>> in drivers/cpufreq/Makefile which depends on that option.
>>
>> Remove unselectable rule for arm-exynos-cpufreq.o from
>> drivers/cpufreq/Makefile.
>>
>> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>> ---
>> I found this inconsistency using the undertaker and
>> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>>
>>  drivers/cpufreq/Makefile | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index bbc4a9f..958be2b 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ)             += arm_big_little_dt.o
>>
>>  obj-$(CONFIG_ARCH_DAVINCI)           += davinci-cpufreq.o
>>  obj-$(CONFIG_UX500_SOC_DB8500)               += dbx500-cpufreq.o
>> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ)     += arm-exynos-cpufreq.o
>>  obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
>>  obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ)   += highbank-cpufreq.o
>>  obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ)  += hisi-acpu-cpufreq.o
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

And again from me:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Dear Kukjin,
Can you take it and send in (updated) pull request with Exynos4x12
cpufreq patches?

BR,
Krzysztof

RE: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o

[Kukjin Kim]

Krzysztof Kozlowski wrote:
> 
> 2015-08-13 20:33 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> > On 13-08-15, 13:28, Jonas Rabenstein wrote:
> >> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
> >> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
> >> in drivers/cpufreq/Makefile which depends on that option.
> >>
> >> Remove unselectable rule for arm-exynos-cpufreq.o from
> >> drivers/cpufreq/Makefile.
> >>
> >> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> >> ---
> >> I found this inconsistency using the undertaker and
> >> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
> >>
> >>  drivers/cpufreq/Makefile | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> >> index bbc4a9f..958be2b 100644
> >> --- a/drivers/cpufreq/Makefile
> >> +++ b/drivers/cpufreq/Makefile
> >> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ)             += arm_big_little_dt.o
> >>
> >>  obj-$(CONFIG_ARCH_DAVINCI)           += davinci-cpufreq.o
> >>  obj-$(CONFIG_UX500_SOC_DB8500)               += dbx500-cpufreq.o
> >> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ)     += arm-exynos-cpufreq.o
> >>  obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> >>  obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ)   += highbank-cpufreq.o
> >>  obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ)  += hisi-acpu-cpufreq.o
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> And again from me:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Dear Kukjin,
> Can you take it and send in (updated) pull request with Exynos4x12
> cpufreq patches?
> 
OK, sure. I'll take this.

Thanks,
Kukjin