Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sangbeom Kim' <sbkim73@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: ben-linux@fluff.org, 'Abhilash Kesavan' <a.kesavan@samsung.com>
Subject: RE: [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416
Date: Wed, 17 Nov 2010 16:39:14 +0900	[thread overview]
Message-ID: <00cc01cb862a$8a17e000$9e47a000$%kim@samsung.com> (raw)
In-Reply-To: <1289954843-27844-1-git-send-email-sbkim73@samsung.com>

Sangbeom Kim wrote:
> 
> From: Abhilash Kesavan <a.kesavan@samsung.com>
> 
> IRQ_S3C2443_UART3 is being used as the base when it should actually
> be IRQ_S3C2443_RX3 on S3C2443 and S3C2416 for the UART3.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> ---
>  arch/arm/mach-s3c2416/irq.c |    2 +-
>  arch/arm/mach-s3c2443/irq.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2416/irq.c b/arch/arm/mach-s3c2416/irq.c
> index 084d121..7844857 100644
> --- a/arch/arm/mach-s3c2416/irq.c
> +++ b/arch/arm/mach-s3c2416/irq.c
> @@ -168,7 +168,7 @@ static struct irq_chip s3c2416_irq_dma = {
> 
>  static void s3c2416_irq_demux_uart3(unsigned int irq, struct irq_desc
*desc)
>  {
> -	s3c2416_irq_demux(IRQ_S3C2443_UART3, 3);
> +	s3c2416_irq_demux(IRQ_S3C2443_RX3, 3);
>  }
> 
>  #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
> diff --git a/arch/arm/mach-s3c2443/irq.c b/arch/arm/mach-s3c2443/irq.c
> index 0e0d693..df2b8db 100644
> --- a/arch/arm/mach-s3c2443/irq.c
> +++ b/arch/arm/mach-s3c2443/irq.c
> @@ -166,7 +166,7 @@ static struct irq_chip s3c2443_irq_dma = {
> 
>  static void s3c2443_irq_demux_uart3(unsigned int irq, struct irq_desc
*desc)
>  {
> -	s3c2443_irq_demux(IRQ_S3C2443_UART3, 3);
> +	s3c2443_irq_demux(IRQ_S3C2443_RX3, 3);
>  }
> 
>  #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
> --
Looks ok...will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

      reply	other threads:[~2010-11-17  7:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  0:47 [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416 Sangbeom Kim
2010-11-17  7:39 ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00cc01cb862a$8a17e000$9e47a000$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=a.kesavan@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox