Linux Samsung SOC development
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416
@ 2010-11-17  0:47 Sangbeom Kim
  2010-11-17  7:39 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Sangbeom Kim @ 2010-11-17  0:47 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: Kukjin Kim, ben-linux, Abhilash Kesavan, Sangbeom Kim

From: Abhilash Kesavan <a.kesavan@samsung.com>

IRQ_S3C2443_UART3 is being used as the base when it should actually
be IRQ_S3C2443_RX3 on S3C2443 and S3C2416 for the UART3.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
 arch/arm/mach-s3c2416/irq.c |    2 +-
 arch/arm/mach-s3c2443/irq.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s3c2416/irq.c b/arch/arm/mach-s3c2416/irq.c
index 084d121..7844857 100644
--- a/arch/arm/mach-s3c2416/irq.c
+++ b/arch/arm/mach-s3c2416/irq.c
@@ -168,7 +168,7 @@ static struct irq_chip s3c2416_irq_dma = {
 
 static void s3c2416_irq_demux_uart3(unsigned int irq, struct irq_desc *desc)
 {
-	s3c2416_irq_demux(IRQ_S3C2443_UART3, 3);
+	s3c2416_irq_demux(IRQ_S3C2443_RX3, 3);
 }
 
 #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
diff --git a/arch/arm/mach-s3c2443/irq.c b/arch/arm/mach-s3c2443/irq.c
index 0e0d693..df2b8db 100644
--- a/arch/arm/mach-s3c2443/irq.c
+++ b/arch/arm/mach-s3c2443/irq.c
@@ -166,7 +166,7 @@ static struct irq_chip s3c2443_irq_dma = {
 
 static void s3c2443_irq_demux_uart3(unsigned int irq, struct irq_desc *desc)
 {
-	s3c2443_irq_demux(IRQ_S3C2443_UART3, 3);
+	s3c2443_irq_demux(IRQ_S3C2443_RX3, 3);
 }
 
 #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
-- 
1.6.2.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416
  2010-11-17  0:47 [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416 Sangbeom Kim
@ 2010-11-17  7:39 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2010-11-17  7:39 UTC (permalink / raw)
  To: 'Sangbeom Kim', linux-samsung-soc
  Cc: ben-linux, 'Abhilash Kesavan'

Sangbeom Kim wrote:
> 
> From: Abhilash Kesavan <a.kesavan@samsung.com>
> 
> IRQ_S3C2443_UART3 is being used as the base when it should actually
> be IRQ_S3C2443_RX3 on S3C2443 and S3C2416 for the UART3.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> ---
>  arch/arm/mach-s3c2416/irq.c |    2 +-
>  arch/arm/mach-s3c2443/irq.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2416/irq.c b/arch/arm/mach-s3c2416/irq.c
> index 084d121..7844857 100644
> --- a/arch/arm/mach-s3c2416/irq.c
> +++ b/arch/arm/mach-s3c2416/irq.c
> @@ -168,7 +168,7 @@ static struct irq_chip s3c2416_irq_dma = {
> 
>  static void s3c2416_irq_demux_uart3(unsigned int irq, struct irq_desc
*desc)
>  {
> -	s3c2416_irq_demux(IRQ_S3C2443_UART3, 3);
> +	s3c2416_irq_demux(IRQ_S3C2443_RX3, 3);
>  }
> 
>  #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
> diff --git a/arch/arm/mach-s3c2443/irq.c b/arch/arm/mach-s3c2443/irq.c
> index 0e0d693..df2b8db 100644
> --- a/arch/arm/mach-s3c2443/irq.c
> +++ b/arch/arm/mach-s3c2443/irq.c
> @@ -166,7 +166,7 @@ static struct irq_chip s3c2443_irq_dma = {
> 
>  static void s3c2443_irq_demux_uart3(unsigned int irq, struct irq_desc
*desc)
>  {
> -	s3c2443_irq_demux(IRQ_S3C2443_UART3, 3);
> +	s3c2443_irq_demux(IRQ_S3C2443_RX3, 3);
>  }
> 
>  #define INTMSK_UART3	(1UL << (IRQ_S3C2443_UART3 - IRQ_EINT0))
> --
Looks ok...will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-17  7:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17  0:47 [PATCH 1/2] ARM: S3C24XX: Fix Demux error in UART3 irqs on S3C2443 and S3C2416 Sangbeom Kim
2010-11-17  7:39 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox