From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sangbeom Kim' <sbkim73@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: ben-linux@fluff.org, 'Abhilash Kesavan' <a.kesavan@samsung.com>
Subject: RE: [PATCH] ARM: S5PV210: Fix sysdev related warning messages
Date: Wed, 17 Nov 2010 16:41:09 +0900 [thread overview]
Message-ID: <00cd01cb862a$cee84cb0$6cb8e610$%kim@samsung.com> (raw)
In-Reply-To: <1289974882-14711-1-git-send-email-sbkim73@samsung.com>
Sangbeom Kim wrote:
>
> From: Abhilash Kesavan <a.kesavan@samsung.com>
>
> This patch fixes following warning messages when CONFIG_PM selected.
>
> In file included from arch/arm/mach-s5pv210/mach-smdkv210.c:34:
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only
this
> definition or declaration, which is probably not what you want
> arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device'
> declared inside parameter list
>
> In file included from arch/arm/mach-s5pv210/mach-smdkc110.c:31:
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only
this
> definition or declaration, which is probably not what you want
> arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/pm.c:217: warning: 's3c_pm_show_resume_irqs' defined
> but not used
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> ---
> arch/arm/mach-s5pv210/mach-smdkc110.c | 1 +
> arch/arm/mach-s5pv210/mach-smdkv210.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/mach-smdkc110.c b/arch/arm/mach-
> s5pv210/mach-smdkc110.c
> index 0ad7924..5dd1681 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkc110.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkc110.c
> @@ -13,6 +13,7 @@
> #include <linux/init.h>
> #include <linux/serial_core.h>
> #include <linux/i2c.h>
> +#include <linux/sysdev.h>
>
> #include <asm/mach/arch.h>
> #include <asm/mach/map.h>
> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-
> s5pv210/mach-smdkv210.c
> index bcd7a5d..1fbc45b 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
> @@ -13,6 +13,7 @@
> #include <linux/i2c.h>
> #include <linux/init.h>
> #include <linux/serial_core.h>
> +#include <linux/sysdev.h>
>
> #include <asm/mach/arch.h>
> #include <asm/mach/map.h>
> --
Ok..will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-11-17 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 6:21 [PATCH] ARM: S5PV210: Fix sysdev related warning messages Sangbeom Kim
2010-11-17 7:41 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00cd01cb862a$cee84cb0$6cb8e610$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=a.kesavan@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox