Linux Samsung SOC development
 help / color / mirror / Atom feed
* [PATCH] ARM: S5PV210: Fix sysdev related warning messages
@ 2010-11-17  6:21 Sangbeom Kim
  2010-11-17  7:41 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Sangbeom Kim @ 2010-11-17  6:21 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: Kukjin Kim, ben-linux, Abhilash Kesavan, Sangbeom Kim

From: Abhilash Kesavan <a.kesavan@samsung.com>

This patch fixes following warning messages when CONFIG_PM selected.

In file included from arch/arm/mach-s5pv210/mach-smdkv210.c:34:
arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device' declared inside parameter list
arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device' declared inside parameter list

In file included from arch/arm/mach-s5pv210/mach-smdkc110.c:31:
arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device' declared inside parameter list
arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device' declared inside parameter list
arch/arm/plat-samsung/pm.c:217: warning: 's3c_pm_show_resume_irqs' defined but not used

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
 arch/arm/mach-s5pv210/mach-smdkc110.c |    1 +
 arch/arm/mach-s5pv210/mach-smdkv210.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv210/mach-smdkc110.c b/arch/arm/mach-s5pv210/mach-smdkc110.c
index 0ad7924..5dd1681 100644
--- a/arch/arm/mach-s5pv210/mach-smdkc110.c
+++ b/arch/arm/mach-s5pv210/mach-smdkc110.c
@@ -13,6 +13,7 @@
 #include <linux/init.h>
 #include <linux/serial_core.h>
 #include <linux/i2c.h>
+#include <linux/sysdev.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
index bcd7a5d..1fbc45b 100644
--- a/arch/arm/mach-s5pv210/mach-smdkv210.c
+++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
@@ -13,6 +13,7 @@
 #include <linux/i2c.h>
 #include <linux/init.h>
 #include <linux/serial_core.h>
+#include <linux/sysdev.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
-- 
1.6.2.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] ARM: S5PV210: Fix sysdev related warning messages
  2010-11-17  6:21 [PATCH] ARM: S5PV210: Fix sysdev related warning messages Sangbeom Kim
@ 2010-11-17  7:41 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2010-11-17  7:41 UTC (permalink / raw)
  To: 'Sangbeom Kim', linux-samsung-soc
  Cc: ben-linux, 'Abhilash Kesavan'

Sangbeom Kim wrote:
> 
> From: Abhilash Kesavan <a.kesavan@samsung.com>
> 
> This patch fixes following warning messages when CONFIG_PM selected.
> 
> In file included from arch/arm/mach-s5pv210/mach-smdkv210.c:34:
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only
this
> definition or declaration, which is probably not what you want
> arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device'
> declared inside parameter list
> 
> In file included from arch/arm/mach-s5pv210/mach-smdkc110.c:31:
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/include/plat/pm.h:104: warning: its scope is only
this
> definition or declaration, which is probably not what you want
> arch/arm/plat-samsung/include/plat/pm.h:105: warning: 'struct sys_device'
> declared inside parameter list
> arch/arm/plat-samsung/pm.c:217: warning: 's3c_pm_show_resume_irqs' defined
> but not used
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> ---
>  arch/arm/mach-s5pv210/mach-smdkc110.c |    1 +
>  arch/arm/mach-s5pv210/mach-smdkv210.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/mach-smdkc110.c b/arch/arm/mach-
> s5pv210/mach-smdkc110.c
> index 0ad7924..5dd1681 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkc110.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkc110.c
> @@ -13,6 +13,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_core.h>
>  #include <linux/i2c.h>
> +#include <linux/sysdev.h>
> 
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-
> s5pv210/mach-smdkv210.c
> index bcd7a5d..1fbc45b 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
> @@ -13,6 +13,7 @@
>  #include <linux/i2c.h>
>  #include <linux/init.h>
>  #include <linux/serial_core.h>
> +#include <linux/sysdev.h>
> 
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> --
Ok..will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-17  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17  6:21 [PATCH] ARM: S5PV210: Fix sysdev related warning messages Sangbeom Kim
2010-11-17  7:41 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox