Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
	linux-samsung-soc@vger.kernel.org
Cc: rjw@sisk.pl, jhbird.choi@samsung.com, patches@linaro.org
Subject: RE: [PATCH 1/2] cpufreq: exynos: Fix unsigned variable being checked for negative value
Date: Fri, 25 Jan 2013 10:24:28 -0800	[thread overview]
Message-ID: <013b01cdfb29$37a714a0$a6f53de0$@samsung.com> (raw)
In-Reply-To: <1358932932-14094-1-git-send-email-sachin.kamat@linaro.org>

Sachin Kamat wrote:
> 
> exynos_cpufreq_scale function returns signed value which was
> assigned to an unsigned variable and checked for negative value which
> is always false. Hence make it signed.
> 
> Fixes the following smatch warnings:
> drivers/cpufreq/exynos-cpufreq.c:83 exynos_cpufreq_scale() warn:
> unsigned 'old_index' is never less than zero.
> drivers/cpufreq/exynos-cpufreq.c:89 exynos_cpufreq_scale() warn:
> unsigned 'index' is never less than zero.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Rafael J. Wysocki suggested these 2 patches be taken through the
> Samsung tree.
> ---
>  drivers/cpufreq/exynos-cpufreq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
Looks OK to me, applied.

Thanks.

- Kukjin

      parent reply	other threads:[~2013-01-25 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23  9:22 [PATCH 1/2] cpufreq: exynos: Fix unsigned variable being checked for negative value Sachin Kamat
2013-01-23  9:22 ` [PATCH 2/2] cpufreq: exynos: Initialise return variable Sachin Kamat
2013-01-25 18:26   ` Kukjin Kim
2013-01-25 19:58     ` Rafael J. Wysocki
2013-02-01  1:11       ` Kukjin Kim
2013-01-25 18:24 ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='013b01cdfb29$37a714a0$a6f53de0$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=jhbird.choi@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox