From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Rafael J. Wysocki'" <rjw@sisk.pl>
Cc: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org, jhbird.choi@samsung.com,
patches@linaro.org
Subject: RE: [PATCH 2/2] cpufreq: exynos: Initialise return variable
Date: Thu, 31 Jan 2013 17:11:20 -0800 [thread overview]
Message-ID: <0b7d01ce0019$0cb230f0$261692d0$@samsung.com> (raw)
In-Reply-To: <56645451.dJrUCdvOAX@vostro.rjw.lan>
Rafael J. Wysocki wrote:
>
> On Friday, January 25, 2013 10:26:41 AM Kukjin Kim wrote:
> > Sachin Kamat wrote:
> > >
> > > 'ret' is undefined when the function returns from the first
> > > 'if' condition. Without this patch we get the following warning:
> > >
> > > drivers/cpufreq/exynos-cpufreq.c: In function ‘exynos_target’:
> > > drivers/cpufreq/exynos-cpufreq.c:182:2: warning:
> > > ‘ret’ may be used uninitialized in this function [-Wuninitialized]
> > >
> > > Suggested-by: Jonghwan Choi <jhbird.choi@samsung.com>
> >
> > I modified above to 'Reported-by' because checkpatch complains like
> following...
> >
> > WARNING: Non-standard signature: Suggested-by:
> > #10:
> > Suggested-by: Jonghwan Choi <jhbird.choi@samsung.com>
>
> This tag has been used already, though, and I think it makes sense (more
> than
Yes, agreed.
> Reported-by in this case). I think it may be regarded as standard regardless
> of what checkpatch has to say about that. :-)
>
I see. Let me keep the 'Reported-by' here.
Thanks for your opinion.
- Kukjin
next prev parent reply other threads:[~2013-02-01 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 9:22 [PATCH 1/2] cpufreq: exynos: Fix unsigned variable being checked for negative value Sachin Kamat
2013-01-23 9:22 ` [PATCH 2/2] cpufreq: exynos: Initialise return variable Sachin Kamat
2013-01-25 18:26 ` Kukjin Kim
2013-01-25 19:58 ` Rafael J. Wysocki
2013-02-01 1:11 ` Kukjin Kim [this message]
2013-01-25 18:24 ` [PATCH 1/2] cpufreq: exynos: Fix unsigned variable being checked for negative value Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0b7d01ce0019$0cb230f0$261692d0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=jhbird.choi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox